Closed
Bug 876764
Opened 12 years ago
Closed 11 years ago
Entering customization mode with open customization tab breaks it
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: morpheus3k+bugzilla, Assigned: jaws)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Australis:M6])
Attachments
(1 file)
(deleted),
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
STR:
1. Open some tabs
2. Open Customization mode via Menu Panel
3. Switch to another tab
4. Open Customization mode via Menu Panel (again)
Expected:
Switch to customization tab.
Actual:
Switch to customization tab, but breaks the mode.
Reporter | ||
Updated•12 years ago
|
Blocks: australis-cust
Whiteboard: [Australis:M?]
Comment 1•12 years ago
|
||
Can't reproduce this on current OS X builds. Can you try this build? I suspect Jared's fix for undo close tab fixed this: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-macosx64/1369751904/firefox-24.0a1.en-US.mac.dmg
Comment 2•12 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #1)
> Can't reproduce this on current OS X builds. Can you try this build? I
> suspect Jared's fix for undo close tab fixed this:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-macosx64/
> 1369751904/firefox-24.0a1.en-US.mac.dmg
Egh, scratch that, I can reproduce weirdness, at the very least.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•12 years ago
|
||
First to review wins!
I had this in my patch for the "undo close tab" bug but the patch worked fine without it. It seems that the change was necessary after all :)
Attachment #755021 -
Flags: review?(mconley)
Attachment #755021 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Updated•12 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Comment 4•12 years ago
|
||
Comment on attachment 755021 [details] [diff] [review]
Patch
Oh yeah, totally. How did that stuff get down there after the beforecustomization event fires? :/
I have a sneaking suspicion that was my bad. r=me.
Attachment #755021 -
Flags: review?(mconley) → review+
Assignee | ||
Updated•12 years ago
|
Attachment #755021 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Comment 5•12 years ago
|
||
Whiteboard: [Australis:M?] → [Australis:M?][fixed-in-ux]
Assignee | ||
Updated•12 years ago
|
Whiteboard: [Australis:M?][fixed-in-ux] → [Australis:M6][fixed-in-ux]
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M6][fixed-in-ux] → [Australis:M6]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•