This push removed a file and deleted its corresponding moz.build entry. However, the build slaves were still looking for it. https://hg.mozilla.org/integration/mozilla-inbound/rev/25ea966531ca https://tbpl.mozilla.org/php/getParsedLog.php?id=23814634&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=23815235&tree=Mozilla-Inbound

It appears config.status didn't run for js/src despite a moz.build file changing. Most interesting.

The problem is that MOZBUILD_BACKEND_CHECKED (a global flag used to determine whether moz.build rebuild scan and possibly rebuild has been performed) is defined by the root Makefile and exported to the environment under which js/src executes. js/src should get a "fresh" environment not polluted with this variable.

This should do it. I wish this could be done with make syntax instead of shell. However, SUBMAKE gets $(call)ed inside a recipe and thus its output is evaluated as shell commands, not make. It's ugly.

Comment on attachment 761737 [details] [diff] [review] Don't export MOZBUILD_BACKEND_CHECKED to independent build systems Review of attachment 761737 [details] [diff] [review]: ----------------------------------------------------------------- ::: config/rules.mk @@ +428,3 @@ > +@$(UPDATE_TITLE) > ++@if test -n "$(3)"; then \ > + MOZBUILD_BACKEND_CHECKED= $(MAKE) $(if $(2),-C $(2)) $(1); \ So, you could write this as another make $(if), right? +$(if $(3) MOZBUILD_BACKEND_CHECKED= ) $(MAKE) $(if $(2),-C $(2)) $(1)

Comment on attachment 761737 [details] [diff] [review] Don't export MOZBUILD_BACKEND_CHECKED to independent build systems Review of attachment 761737 [details] [diff] [review]: ----------------------------------------------------------------- Clearing review till you consider my proposal.

Switched to inline $(if) (I keep forgetting this exists).

This needs to be fixed immediately.

Comment on attachment 763691 [details] [diff] [review] Don't export MOZBUILD_BACKEND_CHECKED to independent build systems Review of attachment 763691 [details] [diff] [review]: ----------------------------------------------------------------- r=me if this doesn't break pymake.