Closed
Bug 881219
Opened 11 years ago
Closed 11 years ago
When filtering sources, hiding items in the sources list is redundant
Categories
(DevTools :: Debugger, enhancement, P3)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: vporof, Assigned: vporof)
References
Details
Attachments
(3 files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
While filtering files, as you type, a completion popup displaying all the matched sources is shown. At the same time, unmatched entries in the sources list on the left are hidden. This creates a redundant scenario in which matched sources are displayed in two places at the same time.
Example (STR):
1. Open debugger on http://todomvc.com/architecture-examples/backbone/
2. Type "to" in the filter box (without quotes)
Result: 4 matched files are shown both in the popup and the sources list.
Assignee | ||
Updated•11 years ago
|
Severity: normal → enhancement
Priority: -- → P3
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #801410 -
Flags: review?(rcampbell)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #801411 -
Flags: review?(rcampbell)
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Comment 3•11 years ago
|
||
The amount dependent patches to test this out is pretty high. Get your builds from here: https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/vporof@mozilla.com-fefd4e522879/
Try: https://tbpl.mozilla.org/?tree=Try&pusher=vporof@mozilla.com
Assignee | ||
Comment 4•11 years ago
|
||
Actual try link: https://tbpl.mozilla.org/?tree=Try&rev=fefd4e522879
Comment 5•11 years ago
|
||
Comment on attachment 801410 [details] [diff] [review]
dbg-filter-redundant.patch
Review of attachment 801410 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/devtools/debugger/debugger-toolbar.js
@@ +1278,3 @@
>
> + // Allow requests to settle down first.
> + setNamedTimeout("sources-search", delay, () => this._doSearch(aToken));
eh?
Attachment #801410 -
Flags: review?(rcampbell) → review+
Updated•11 years ago
|
Attachment #801411 -
Flags: review?(rcampbell) → review+
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to Rob Campbell [:rc] (:robcee) from comment #5)
> Comment on attachment 801410 [details] [diff] [review]
Bug 891439.
Assignee | ||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/ead76fb1a864
https://hg.mozilla.org/integration/fx-team/rev/47cc9c07b703
Whiteboard: [fixed-in-fx-team]
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ead76fb1a864
https://hg.mozilla.org/mozilla-central/rev/47cc9c07b703
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•