Closed Bug 884718 Opened 11 years ago Closed 11 years ago

pixel left behind with dynamic-text-06.svg on Android with svg.text.css-frames.enabled

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(3 files, 1 obsolete file)

Attached file reftest log (deleted) —
The one remaining test failure with svg.text.css-frames.enabled is a one pixel difference in dynamic-text-06.svg on Android. Reftest log snippet attached.
The failure is random, too. If I change the test https://hg.mozilla.org/try/rev/3bdbdd9c1feb to have a one second delay between each tick of the animation, then I don't get the single pixel failure.
Attached file reftest log, with increased tick delay (obsolete) (deleted) —
Sorry, with that try run I neglected to set the pref. Changing the delay just makes the failure more obvious: https://tbpl.mozilla.org/?tree=Try&rev=f4d4106b1dda
Attachment #766274 - Attachment is obsolete: true
Blocks: 839955
Attached patch patch (deleted) — Splinter Review
I guess we're getting rounding errors somewhere in the process of taking the rectangles of each rendered run, converting them into user space and then converting back to the mRect coordinate space, although I didn't actually dig deep enough to find where this was happening. So while I think this is OK for the moment, at some point it'd be worth tracking down where the error is coming in, in case we should be doing the inflation (or rounding differently) at some other stage.
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #769367 - Flags: review?(roc)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Depends on: 1519144
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: