Open Bug 884987 Opened 11 years ago Updated 2 years ago

NSPR DragonFly platform support

Categories

(NSPR :: NSPR, defect)

Product:
NSPR
Component:
NSPR
Platform:
All
Other
Type:
defect

Tracking

(Not tracked)

People

(Reporter: ftigeot, Unassigned)

Details

Attachments

(4 files, 3 obsolete files)

New file: _dragonfly.cfg
(deleted), patch
Details | Diff | Splinter Review
New file: _dragonfly.h
(deleted), text/x-chdr
Details
Adapt uxwrap.c for DragonFly poll(2) support
(deleted), patch
Details | Diff | Splinter Review
New file: _dragonfly.h
(deleted), patch
Details | Diff | Splinter Review
Until now, the freebsd platform files have been used to build nspr on DragonFly but this is not ideal. It would be better to handle DragonFly as a separate platform like it is done with most operating systems.
Attached file DragonFly-specific platform file (obsolete) (deleted) —
Attached file DragonFly-specific platform file (obsolete) (deleted) —
These first two attached files should be put into the pr/include/md/ directory.
Attached patch Patch adding two DragonFly-specific files (obsolete) (deleted) — — Splinter Review
Same files, in a git-style patch
Attachment #764954 - Attachment is obsolete: true
Attachment #764956 - Attachment is obsolete: true
Comment on attachment 764980 [details] [diff] [review] Patch adding two DragonFly-specific files trailing & wrong #endif /* nspr_freebsd_defs_h___ */ at the bottom of the diff :) Deferring to wtc
Attachment #764980 - Flags: review?(wtc)
The comment is indeed wrong, the last line should be: #endif /* nspr_dragonfly_defs_h___ */ Not sure if that's worth an updated patch file...
Attachment #764980 - Flags: review?(ted)
Comment on attachment 764980 [details] [diff] [review] Patch adding two DragonFly-specific files Review of attachment 764980 [details] [diff] [review]: ----------------------------------------------------------------- This seems fine, although I don't really know enough details to comment more specifically.
Attachment #764980 - Flags: review?(ted) → review+
Francois, is this still accurate wrt the specificites of dfly those days ? If so i'll land it soonish (with the nit from comment #6...)
Flags: needinfo?(ftigeot)
The patch is still good even though it now contains some obsolete parts. I'll open a separate bug report later to remove 32-bit x86 support if this code ever makes it to the nspr repository.
Flags: needinfo?(ftigeot)
ted, shall i just land it as-is to nspr repo, or some approval is needed ? i never remember the rules for this repo.. Francois, what's the obsolete 32-bits chunk besides +#define _PR_SI_ARCHITECTURE "x86" ?
The code protected with defined(__i386__) includes in _dragonfly.cfg
You need an NSPR peer to land NSPR patches for you. If this is ready to go then needinfo me and I'll land it.
francois, can you upload a fixed patch without the i386/32 bits parts so that ted can finally land this ?
Flags: needinfo?(ftigeot)
Attached patch New file: _dragonfly.cfg (deleted) — — Splinter Review
Attachment #764980 - Attachment is obsolete: true
Attachment #764980 - Flags: review?(wtc)
Flags: needinfo?(ftigeot)
Attached file New file: _dragonfly.h (deleted) —
Attached patch New file: _dragonfly.h (deleted) — — Splinter Review
I have updated the patches and added missing poll(2) support in the process.
Flags: needinfo?(ted)
I have resigned as NSPR module owner. Sorry for the inconvenience.
Flags: needinfo?(ted)
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: wtc → nobody
Status: ASSIGNED → NEW
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: