Closed
Bug 887116
Opened 11 years ago
Closed 11 years ago
Get rid of contentutils refcounting in CallbackObject
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: bzbarsky, Assigned: nsm)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
See bug 845545 comment 9.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → nsm.nikhil
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #789809 -
Flags: review?(khuey)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #789806 -
Attachment is obsolete: true
Attachment #789809 -
Flags: review?(khuey) → review+
|
||
Comment 3•11 years ago
|
||
Comment on attachment 789809 [details] [diff] [review]
Don't hold a reference to nsLayoutStatics in WebIDL CallbackObject.
Review of attachment 789809 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/bindings/CallbackObject.h
@@ +96,5 @@
> MOZ_ASSERT(aCallback && !mCallback);
> // Set mCallback before we hold, on the off chance that a GC could somehow
> // happen in there... (which would be pretty odd, granted).
> mCallback = aCallback;
> // Make sure we'll be able to drop as needed
You should drop this comment, as it refers to the AddRef().
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
|
Reporter | |
Comment 6•11 years ago
|
||
Is there a reason the nsLayoutStatics.h include wasn't removed too?
Flags: needinfo?(nsm.nikhil)
|
|
||
Comment 7•11 years ago
|
||
I think it actually breaks a bunch of stuff that was bootlegging in nsThreadUtils.h. I'm working on removing it (and others) in bug 904826.
Flags: needinfo?(nsm.nikhil)
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•