Closed Bug 888153 Opened 11 years ago Closed 11 years ago

[contacts] Import from vCard 4.0 has email missing in Contacts app

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

RESOLVED FIXED
blocking-b2g leo+
Tracking Status
b2g18 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: parul, Assigned: sergi)

References

Details

(Whiteboard: [LeoVB-])

Attachments

(3 files)

Test Environment: Device: Leo phone Build Identifier: 20130624070224 Update channel: leo/1.1.0/nightly Git commit info: 2013-06-24 11:42:38 Gaia Version: 885b874029d8143035765ae903c147a9415fcc521372074158 Gecko: 62049a1c5d36 OS version: 1.1.0.0-prerelease Platform version: 18.1 Prerequisites: Copy a vCard in 4.0 format on the SD Card of the phone. Ensure that the email field is filled out. (see attached vCard or see http://en.wikipedia.org/wiki/VCard) Ensure USB storage is not enabled on the phone. Steps to reproduce: 1. On the phone home screen, tap on the Contacts icon to launch the Contacts app. 2. In the Contacts app, tap on the gear icon at the top right to import contacts from SD Card. 3. On the Contacts Settings screen, tap on "SD Card" to start the import. 4. On the Contacts screen, tap on the imported contact. Expected results: The email field in the vCard 4.0 format is correctly parsed and displayed in the Contacts app. Actual results: The email field in the vCard 4.0 format is not displayed in the Contacts app. (see screenshot attached)
Attached file vCard 4.0 format (deleted) —
The VCF file you attached doesn't contain an Email. Am I missing something?
Flags: needinfo?(parul)
Yes, I was missing something. My editor was truncating the text, my apologies.
Flags: needinfo?(parul)
Assignee: nobody → sergi.mansilla
Attached patch Github Pull Request (deleted) — Splinter Review
Fixed vCard 4.0 parsing: Fixed tel: prefix issues. Improved parser, it is not based on regex anymore. Parses several meta fields now, not only one. Added Unit tests.
Attachment #773531 - Flags: review?(francisco.jordano)
Comment on attachment 773531 [details] [diff] [review] Github Pull Request r+ once small nit commented in github is solved. Thanks a lot Sergi.
Attachment #773531 - Flags: review?(francisco.jordano) → review+
Merged in fd0d621e8c1cfbc9afc9af317edb8bb03dc77ed5 Thanks Francisco!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
blocking-b2g: --- → leo?
This bug prevents vCard 4.0 from being imported properly. Some popular applications like Outlook may use this format to export contacts, and in that case, FFOS won't import them properly, thus the request for leo+.
Busted functionality for a new feature in 1.1 hence blocking
blocking-b2g: leo? → leo+
Uplifted fd0d621e8c1cfbc9afc9af317edb8bb03dc77ed5 to: v1-train: e89f039eba23d0cc8445d8352753d53a475ffd4b
Whiteboard: [LeoVB+]
v1.1.0hd: e89f039eba23d0cc8445d8352753d53a475ffd4b
Whiteboard: [LeoVB+] → [LeoVB-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: