Closed Bug 889204 Opened 11 years ago Closed 11 years ago

Test that `this` is a sidebar instance in event handlers for sidebars

Categories

(Add-on SDK Graveyard :: General, defect, P2)

Product:
Add-on SDK Graveyard
Component:
General
Platform:
x86
All
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: evold, Assigned: evold)

References

Details

Attachments

(1 file)

Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1095
(deleted), text/html
jsantell
: review+
Details
Making `this` the component instance seems to be pretty standard in the SDK apis, and I forgot to test if this works for sidebars, although I think this may be working atm.
Assignee: nobody → evold
Attachment #773858 - Flags: review?(zer0)
Comment on attachment 773858 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1095 Moving my review requests from Matteo to someone else.
Attachment #773858 - Flags: review?(zer0) → review?(jsantell)
Comment on attachment 773858 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1095 Nits, R+
Attachment #773858 - Flags: review?(jsantell) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/d9ed5016fe13912b918d232d4f6f90586d48cc13 Bug 889204 testing sidebar event listeners thoroughly https://github.com/mozilla/addon-sdk/commit/f02f4d1c2362acca600cd77068d423a532f18996 Merge pull request #1095 from erikvold/889204 Bug 889204 testing sidebar event listeners thoroughly r=@jsantell
I'm going through the list of open bugs that github robot has commented in. Is this bug fixed, Erik?
Flags: needinfo?(evold)
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(evold)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: