Closed
Bug 893315
Opened 11 years ago
Closed 11 years ago
More use of Move need renaming to mozilla::Move.
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: dougc, Assigned: dougc)
Details
Attachments
(1 file)
|
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
A few more uses of Move might need renaming to mozilla::Move after Bug 891177.
|
Assignee | |
Comment 1•11 years ago
|
||
Might these uses of Move need renaming to mozilla::Move.
Attachment #775085 -
Flags: review?
|
||
Comment 2•11 years ago
|
||
Comment on attachment 775085 [details] [diff] [review]
Bug 893315 - More uses of Move need renaming to mozilla::Move
Seems reasonable, assuming Move means to refer to mozilla::Move there and not to (?) js::ion::Move -- likely, given the names of stuff here, but you never know. If this compiles it's good.
Attachment #775085 -
Flags: review? → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #2)
> Comment on attachment 775085 [details] [diff] [review]
> Bug 893315 - More uses of Move need renaming to mozilla::Move
>
> Seems reasonable, assuming Move means to refer to mozilla::Move there and
> not to (?) js::ion::Move -- likely, given the names of stuff here, but you
> never know. If this compiles it's good.
Yes, it compiles. Thank you for the quick review.
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•