Closed Bug 893317 Opened 11 years ago Closed 11 years ago

Fix VTune include files.

Categories

(Core :: JavaScript Engine, defect)

All
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: dougc, Assigned: dougc)

Details

Attachments

(1 file)

The VTune include files were lost in some prior patch, probably the include file clean up work.
Attached patch Fix VTune include files (deleted) — Splinter Review
Attachment #775089 - Flags: review?(sstangl)
Comment on attachment 775089 [details] [diff] [review] Fix VTune include files Review of attachment 775089 [details] [diff] [review]: ----------------------------------------------------------------- I think I removed these, IIRC it was because I couldn't find jitprofiling.h in the repo. But looking at configure.in I figure it must be a file within VTune itself? r=me assuming that's true. Also, there are MOZ_VTUNE chunks of code in shell/js.cpp and ion/AsmJSModule.h. Should jitprofiling.h be conditionally-included in those files as well?
Attachment #775089 - Flags: review?(sstangl) → review+
Thank you for the quick review. The VTune support does compile with just the included patch, so it does not appear to be necessary to include jitprofiling.h in the other files noted in comment 2.
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: