Closed
Bug 893317
Opened 11 years ago
Closed 11 years ago
Fix VTune include files.
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: dougc, Assigned: dougc)
Details
Attachments
(1 file)
(deleted),
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
The VTune include files were lost in some prior patch, probably the include file clean up work.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #775089 -
Flags: review?(sstangl)
Comment 2•11 years ago
|
||
Comment on attachment 775089 [details] [diff] [review]
Fix VTune include files
Review of attachment 775089 [details] [diff] [review]:
-----------------------------------------------------------------
I think I removed these, IIRC it was because I couldn't find jitprofiling.h in the repo. But looking at configure.in I figure it must be a file within VTune itself? r=me assuming that's true.
Also, there are MOZ_VTUNE chunks of code in shell/js.cpp and ion/AsmJSModule.h. Should jitprofiling.h be conditionally-included in those files as well?
Attachment #775089 -
Flags: review?(sstangl) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Thank you for the quick review. The VTune support does compile with just the included patch, so it does not appear to be necessary to include jitprofiling.h in the other files noted in comment 2.
Keywords: checkin-needed
Comment 4•11 years ago
|
||
Keywords: checkin-needed
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•