Closed
Bug 895960
Opened 11 years ago
Closed 11 years ago
SIM Contact import does not work on particular types of SIMs
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: zcampbell, Assigned: allstars.chh)
References
Details
(Whiteboard: [fixed-in-birch])
Attachments
(5 files, 1 obsolete file)
(deleted),
image/png
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
hsinyi
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
hsinyi
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
1. Using an Android phone, create a contact on the device.
2. Use "Copy to SIM"[1] app to move that contact onto the SIM card.
3. Switch that SIM into a Firefox OS phone
4. Open Contacts app
5. From settings menu perform 'Import from SIM'
6. Contact import will fail (see screenshot)
The SIM Contact can be read by other Android phones (tested on several).
This is valid for both current v1-train and m-c builds and has been so for months (but I've only just been able to check our phones here in MV).
This could hurt new users migrating from Android to Firefox OS.
[1] "Copy to SIM" app:
https://play.google.com/store/apps/details?id=com.shao.Copy2SIM&hl=en
Comment 1•11 years ago
|
||
Can you paste the logcat?
Reporter | ||
Comment 2•11 years ago
|
||
Assignee | ||
Comment 3•11 years ago
|
||
I'll check this.
Meanwhile Zac can you provide your gecko/gaia version ?
Thanks
Assignee: nobody → allstars.chh
Comment 4•11 years ago
|
||
reproducible for me, i cant use my keon because of this bug, well nightly is working
Reporter | ||
Comment 5•11 years ago
|
||
Yoshi, since I filed this I have found the difference here to be the SIM card itself rather than the method of copying.
You may mark this invalid and file a new one, or re-name this one?
quote email:
---
I have here 5 SIMs - 2 AT&T, one T-Mo, one English '3' and one English T-Mo SIM. For the two AT&T SIMs I cannot import a contact from the SIM with either m-c or v1-train builds and haven't been able to for weeks. For the other two they work fine.
I have used an Android 3 phone and an Android 4 phone to install contacts on them but it does not seem to make a difference. Firefox OS just cannot import from the two AT&T SIMs.
---
Assignee | ||
Comment 6•11 years ago
|
||
Hi, Zac
Can you test this patch for me?
I think this bug is SIM-dependant, unfortunally I don't have this kind of SIM at hand.
So I request for your feedback here.
Thanks
Attachment #779621 -
Flags: feedback?(zcampbell)
Reporter | ||
Comment 7•11 years ago
|
||
Hi Yoshi can you do a Try build for us? I can't self-build Gaia sorry.
Also how do we tell the difference between the types of SIMs?
Reporter | ||
Updated•11 years ago
|
Summary: SIM contact created by "Copy to SIM" Android app cannot be imported → SIM Contact import does not work on particular types of SIMs
Assignee | ||
Comment 8•11 years ago
|
||
(In reply to Zac C (:zac) from comment #7)
I use try chooser hg extension,
but the try chooser has some problems here, it still uses ics_armv7a_gecko, I think the try server has renamed it to 'emulator'.
> Also how do we tell the difference between the types of SIMs?
There seems no obvious way to tell, this are (SIM) vendor-dependant.
we can only read the content on the SIM.
Reporter | ||
Comment 9•11 years ago
|
||
Thanks Yoshi. I'll find someone to help us out with testing this!
Assignee | ||
Comment 10•11 years ago
|
||
Hi, Zac
I'll try to land this today.
You can wait for it's landed in m-c to test again.
Thanks
Assignee | ||
Updated•11 years ago
|
Attachment #779621 -
Flags: feedback?(zcampbell)
Reporter | ||
Comment 11•11 years ago
|
||
Thanks yoshi, I can't find anyone to test this for me in MV (I am not in MV) but if it does go into the nightly m-c build then i can see the test results remotely! ;)
Assignee | ||
Updated•11 years ago
|
Attachment #779621 -
Attachment description: 0001-Bug-895960-SIM-contact-created-by-Copy-to-SIM-Androi.patch → Part 1: Patch
Assignee | ||
Comment 12•11 years ago
|
||
Assignee | ||
Comment 13•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #779621 -
Flags: review?(htsai)
Assignee | ||
Updated•11 years ago
|
Attachment #783042 -
Flags: review?(htsai)
Assignee | ||
Updated•11 years ago
|
Attachment #783044 -
Flags: review?(htsai)
Comment 14•11 years ago
|
||
Comment on attachment 779621 [details] [diff] [review]
Part 1: Patch
Thank you.
Attachment #779621 -
Flags: review?(htsai) → review+
Comment 15•11 years ago
|
||
Comment on attachment 783042 [details] [diff] [review]
Part 2: xpcshell test case.
Review of attachment 783042 [details] [diff] [review]:
-----------------------------------------------------------------
Great~
Attachment #783042 -
Flags: review?(htsai) → review+
Updated•11 years ago
|
Attachment #783044 -
Flags: review?(htsai) → review+
Assignee | ||
Updated•11 years ago
|
Component: Gaia::Contacts → DOM: Device Interfaces
Product: Boot2Gecko → Core
Version: unspecified → Trunk
Assignee | ||
Comment 18•11 years ago
|
||
http://hg.mozilla.org/projects/birch/rev/d2c1d22cc676
http://hg.mozilla.org/projects/birch/rev/85b55d36686f
http://hg.mozilla.org/projects/birch/rev/daf9df1e2cd2
Whiteboard: [fixed-in-birch]
Comment 19•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d2c1d22cc676
https://hg.mozilla.org/mozilla-central/rev/85b55d36686f
https://hg.mozilla.org/mozilla-central/rev/daf9df1e2cd2
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Reporter | ||
Comment 20•11 years ago
|
||
Yoshi, our tests have just started passing!
Reporter | ||
Comment 21•11 years ago
|
||
Yoshi, do you need any more information or debugging from us?
This is passing well for us and has not caused a regression on the other type of SIMs so we're happy!
Flags: needinfo?(allstars.chh)
Assignee | ||
Comment 22•11 years ago
|
||
Great, no more information is needed.
Thanks for your help.
Flags: needinfo?(allstars.chh)
Reporter | ||
Comment 25•11 years ago
|
||
Yoshi, any chance of getting this uplifted to v1-train?
blocking-b2g: --- → leo?
Flags: needinfo?(allstars.chh)
Assignee | ||
Comment 26•11 years ago
|
||
No, the older code even don't check in into b2g18 nor b2g18_v1.0.1.
Flags: needinfo?(allstars.chh)
Reporter | ||
Updated•11 years ago
|
blocking-b2g: leo? → ---
Reporter | ||
Comment 27•11 years ago
|
||
Thanks Yoshi
You need to log in
before you can comment on or make changes to this bug.
Description
•