Closed Bug 899926 Opened 11 years ago Closed 11 years ago

Visual refresh for call duration when call has ended

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

defect

Tracking

(feature-b2g:2.0, tracking-b2g:backlog)

RESOLVED DUPLICATE of bug 951606
feature-b2g 2.0
tracking-b2g backlog

People

(Reporter: sync-1, Assigned: gtorodelvalle)

References

Details

(Whiteboard: [ucid: comms48, 2.0, FT:COMMS] [priority])

Attachments

(7 files, 20 obsolete files)

(deleted), image/png
Details
(deleted), image/png
Details
(deleted), image/png
Details
(deleted), image/png
Details
(deleted), image/png
Details
(deleted), image/png
Details
(deleted), image/png
Details
AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.171 Firefox os v1.1 Mozilla build ID:20130722070207 DEFECT DESCRIPTION: When end call,it does not display the length of time be used REPRODUCING PROCEDURES: 1.dial a call(10010), wait the call connected 2.end the call, it is not display the total duration time of the call --> KO EXPECTED BEHAVIOUR: when a connected call ended, it should display the total duration time of the call ASSOCIATE SPECIFICATION: TEST PLAN REFERENCE: USER IMPACT: Middle REPRODUCING RATE: 5/5 For FT PR, Please list reference mobile's behavior:
blocking-b2g: --- → koi?
adding to backlog 891754
blocking-b2g: koi? → ---
Attached image Dialer.CallEnded_timestamp.png (obsolete) (deleted) —
Hi Carrie, please confirm if this visual proposal it's OK from IxD perspective. Thanks!
Flags: needinfo?(cawang)
Attached image Dialer.SPEC.CallEnded_timestamp.png (obsolete) (deleted) —
Hi Jose, Yes, it looks fine to me! :) Thanks!
Flags: needinfo?(cawang)
Assignee: nobody → gtorodelvalle
Hi guys, I have a preliminary working version of the requested functionality but I have doubts regarding the fact that we are not currently including the total call duration in a couple of cases, apart from the one considered in this bug, these are: (1) when ending calls in the group call (see attached screenshot) and (2) when ending calls in call holding scenarios (see attached screenshot). Are these cases considered in any other bug I am not aware of? Should we consider those cases in this very bug? :) Thanks!
Attached image [screenshot] Ending a group call (obsolete) (deleted) —
(In reply to gtorodelvalle from comment #5) > Hi guys, I have a preliminary working version of the requested functionality > but I have doubts regarding the fact that we are not currently including the > total call duration in a couple of cases, apart from the one considered in > this bug, these are: (1) when ending calls in the group call (see attached > screenshot) and (2) when ending calls in call holding scenarios (see > attached screenshot). Are these cases considered in any other bug I am not > aware of? Should we consider those cases in this very bug? :) Thanks! I think we should consider them as part of this bug, ni to José to provide the visual proposal covering them. Thanks for pointing it out!
Flags: needinfo?(vittone)
Attached image [screenshot] Ending a call before establishing it (obsolete) (deleted) —
On the other hand I have a doubt about a so to call it corner case :-) This is the case when the incoming or outgoing call has not been already established and the screen shows "Incoming" or "Connecting" respectively. If any party hangs up the call, should we show: "Call Ended 00:00" Right now this is what I have currently implemented (see the screenshot) but could be adapted to what it may be desired, of course ;-)
Flags: needinfo?(cawang)
Related to comment 8 and although I already commented it to Jose, just wanted to point out that the current implementation of the hanging of calls when other calls are on hold does not reflect the designed visuals (see provided image and screenshot). I do not want what are the plans to implement that screen and if we should consider showing the total duration of the call regarding the current or design cases :-)
(In reply to gtorodelvalle from comment #9) > Created attachment 8376124 [details] > [screenshot] Ending a call before establishing it > > On the other hand I have a doubt about a so to call it corner case :-) This > is the case when the incoming or outgoing call has not been already > established and the screen shows "Incoming" or "Connecting" respectively. If > any party hangs up the call, should we show: > "Call Ended > 00:00" > Right now this is what I have currently implemented (see the screenshot) but > could be adapted to what it may be desired, of course ;-) Maybe in that case you don't need to show anything as the connection was not even established. so it would be a "null connection" that didn't have any duration.
(In reply to Jose M. Cantera from comment #12) > (In reply to gtorodelvalle from comment #9) > > Created attachment 8376124 [details] > > [screenshot] Ending a call before establishing it > > > > On the other hand I have a doubt about a so to call it corner case :-) This > > is the case when the incoming or outgoing call has not been already > > established and the screen shows "Incoming" or "Connecting" respectively. If > > any party hangs up the call, should we show: > > "Call Ended > > 00:00" > > Right now this is what I have currently implemented (see the screenshot) but > > could be adapted to what it may be desired, of course ;-) > > Maybe in that case you don't need to show anything as the connection was not > even established. so it would be a "null connection" that didn't have any > duration. I agree with you Jose Cantera on this one, but I'd like to know Carrie's thoughts on this. Perhaps you want to know that you spent $0 on that call or it goes without saying. I'm working on the not covered cases, thanks German for that ;)
Hi guys, I think if the call is not established, then we shouldn't add the time duration in this case. If the user is the one hung up the phone, he might be confused and think that he answered it accidentally. Thanks!
Flags: needinfo?(cawang)
Attached image Call_Ended_Duration.png (obsolete) (deleted) —
Flags: needinfo?(vittone)
Attached image [visual] Call_Ended_Duration.png (obsolete) (deleted) —
Based on the latest dialer visuals this is the proposal to add the call duration when the call is ended.
Attachment #8373295 - Attachment is obsolete: true
Attached image SPEC.Dialer.Call_Ended_Duration.png (obsolete) (deleted) —
Attachment #8373296 - Attachment is obsolete: true
Attachment #8377585 - Attachment is obsolete: true
Attachment #8377589 - Attachment description: SPEC.Dialer.incomming_call.png → SPEC.Dialer.Call_Ended_Duration.png
Attachment #8377589 - Attachment filename: SPEC.Dialer.incomming_call.png → SPEC.Dialer.Call_Ended_Durationpng
Attached image [visual] Call_Ended_Duration-multiple.png (obsolete) (deleted) —
Attachment #8376130 - Attachment is obsolete: true
Attachment #8377588 - Attachment description: Call_Ended_Duration.png → [visual] Call_Ended_Duration.png
Attached image [visual] ConferenceCall_list.png (obsolete) (deleted) —
Attached image [visual] Call_Status_bar.png (deleted) —
Attached image SPEC.Call_status_bar.call-ended.png (deleted) —
Attached image SPEC.Dialer.conference-list.call-ended.png (obsolete) (deleted) —
Attached image SPEC.Dialer.conference.call-ended.png (obsolete) (deleted) —
After discussing it with Noemí and Jose and since we found many visual discrepancies between what's currently implemented in master regarding the Dialer and the specifications and visuals provided by UX, we decided to make a proposal of implementation for this bug based on what's currently implemented and not on what should be implemented. The alignment of the current implementation and the Dialer and the specs will be covered in a future bug. In fact, Jose is working on identifying these discrepancies based on the screenshots I have provided him. Consequently, I am going to attach some screenshots of the solution proposed to this bug, as I said based on the current implementation of the Dialer in master :-) We will then ask for the OK by Wilfred to make the corresponding pull request and get it landed in master. Thanks!
Attachment #8376105 - Attachment is obsolete: true
Attachment #8376107 - Attachment is obsolete: true
Attachment #8376124 - Attachment is obsolete: true
Attachment #8376131 - Attachment is obsolete: true
If the call is established, the duration of the call is shown.
If the call is not established, no duration information is shown.
If the call is established, the duration is shown once the call ends.
No duration information is shown if the call is not established.
attachment 8377626 [details] is not currently implemented in master and consequently it has not been adapted in the patch I have prepared. In fact, not really sure what duration UX is planning to provide there (the current ongoing conference duration until the moment the concrete party hung up?). Anyhow, this will be covered in the bug Jose is preparing regarding the discrepancies between the current implementation and the proposed specs so let's not focus on it here ;-)
Although I think this visual has not been attached to this bug, Jose, I have adapted the page when a conference call is finished by the moderator or administrator (so to call it). In this case, the duration information is always shown since there is no way to reject the establishment of a conference call. It is always established ;-)
attachment 8377627 [details] is not currently implemented in master and consequently it has not been adapted in the patch I have prepared either. BTW, in the current implementation in master, if the ongoing call is "minimized" to the top of the screen (with the green background) and the called party hangs up the call, the (so to call it) green background banner is moved out of the screen by the top. No red background or "Call ended" text is shown.
ni to Wilfred to confirm the proposal for including call duration info in v1.4 based on what's currently implemented (please see screenshots attached by German). The visual gap between the current implementation and the specs coming from visual team for dialer will be properly prioritized and addressed (out of the scope of this bug), José is gathering all the discrepancies in a single document that will help on having a clear picture about it. Thanks!
Flags: needinfo?(wmathanaraj)
call duration is out of v1.4 due to reduced scope and time we have for v1.4. I am backlogging this item and we can perhaps do this as part of the work of visual refresh - but needs evaluation how far away we far with the gap document. if visual refresh captures the gap and addresses it then we have a good chance to do this.
blocking-b2g: --- → backlog
Flags: needinfo?(wmathanaraj)
Attached image SPEC.Dialer.Call_Ended_Duration.png (obsolete) (deleted) —
Attachment #8377589 - Attachment is obsolete: true
Attached image SPEC.Dialer.conference.call-ended.png (obsolete) (deleted) —
Attachment #8377631 - Attachment is obsolete: true
Attached image [visual] Call_Ended_Duration-multiple.png (obsolete) (deleted) —
Attachment #8377625 - Attachment is obsolete: true
Attached image [visual] Call_Ended_Duration.png (obsolete) (deleted) —
Attachment #8377588 - Attachment is obsolete: true
I've updated the visuals following the visual refresh.
Attached image SPEC.Dialer.call-ended.png (obsolete) (deleted) —
Attachment #8382955 - Attachment is obsolete: true
Attached image [visual] Call_Ended_Duration.png (obsolete) (deleted) —
Attachment #8382958 - Attachment is obsolete: true
blocking-b2g: backlog → 1.5?
Blocks: 951606
added to 1.5 targeted
blocking-b2g: 1.5? → backlog
No longer blocks: 1.4-comms-targeted
Whiteboard: [priority]
Depends on: 1003846
Summary: [Buri][CTA][Call]When end call,it does not display the call duration → Visual refresh for call duration when call has ended
Attachment #8377626 - Attachment is obsolete: true
Attachment #8383056 - Attachment is obsolete: true
Attachment #8383055 - Attachment is obsolete: true
Hi, Visual refresh for call duration when call has ended will be handled within Bug 951606 (VR for call screen) and the visual specs will be available in Bug 950760 (VR meta dialer). Thanks!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Attachment #8377629 - Attachment is obsolete: true
Attachment #8382956 - Attachment is obsolete: true
Attachment #8382957 - Attachment is obsolete: true
feature-b2g: --- → 2.0
QA Contact: lolimartinezcr
Whiteboard: [priority] → [ucid: comms48, 2.0, FT:COMMS] [priority]
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: