Closed
Bug 902488
Opened 11 years ago
Closed 11 years ago
WebGL2 Occlusion queries optimization on desktop
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: guillaume.abadie, Assigned: guillaume.abadie)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•11 years ago
|
Summary: WebGL2 Improve occlusion queries → WebGL2 Occlusion queries optimization on desktop
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #786967 -
Flags: review?(jgilbert)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #786967 -
Attachment is obsolete: true
Attachment #786967 -
Flags: review?(jgilbert)
Attachment #787005 -
Flags: review?(jgilbert)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 787005 [details] [diff] [review]
patch revision 2
Review of attachment 787005 [details] [diff] [review]:
-----------------------------------------------------------------
Nits.
::: content/canvas/src/WebGLContextAsyncQueries.cpp
@@ +42,5 @@
> + target == LOCAL_GL_ANY_SAMPLES_PASSED_CONSERVATIVE,
> + "unknown occlusion query target");
> +
> + if (gl->IsExtensionSupported(gl::GLContext::XXX_occlusion_query_boolean))
> + {
Brace to end of the previous line.
If this seems too cramped, use:
if (foo) {
return bar;
} else if (qux) {
return bax;
}
@@ +45,5 @@
> + if (gl->IsExtensionSupported(gl::GLContext::XXX_occlusion_query_boolean))
> + {
> + return target;
> + }
> + else if (gl->IsExtensionSupported(gl::GLContext::XXX_occlusion_query2))
`} else`!
Attachment #787005 -
Flags: review?(jgilbert) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
(In reply to Jeff Gilbert [:jgilbert] from comment #3)
> Comment on attachment 787005 [details] [diff] [review]
> patch revision 2
>
> Review of attachment 787005 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Nits.
>
> ::: content/canvas/src/WebGLContextAsyncQueries.cpp
> @@ +42,5 @@
> > + target == LOCAL_GL_ANY_SAMPLES_PASSED_CONSERVATIVE,
> > + "unknown occlusion query target");
> > +
> > + if (gl->IsExtensionSupported(gl::GLContext::XXX_occlusion_query_boolean))
> > + {
>
> Brace to end of the previous line.
Oups...
>
> If this seems too cramped, use:
> if (foo) {
> return bar;
>
> } else if (qux) {
> return bax;
> }
>
> @@ +45,5 @@
> > + if (gl->IsExtensionSupported(gl::GLContext::XXX_occlusion_query_boolean))
> > + {
> > + return target;
> > + }
> > + else if (gl->IsExtensionSupported(gl::GLContext::XXX_occlusion_query2))
>
> `} else`!
Oups...
|
|
Assignee | |
Comment 5•11 years ago
|
||
Target Milestone: --- → mozilla26
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•