Closed
Bug 904
Opened 26 years ago
Closed 25 years ago
Implement repeating, prioritised timers on Mac
Categories
(Core :: DOM: UI Events & Focus Handling, defect, P2)
Tracking
()
VERIFIED
FIXED
M15
People
(Reporter: troy, Assigned: sfraser_bugs)
References
Details
(Keywords: perf, platform-parity, Whiteboard: [PDT-] Fix in hand)
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/plain
|
Details |
The timer API and implementation doesn't support repeating timers, and this
causes a large number of temporary timer objects to be created and
destroyed; e.g., view mgr, throbber, image system services
Updated•26 years ago
|
Status: NEW → ASSIGNED
Comment 2•26 years ago
|
||
per leger, assigning QA contacts to all open bugs without QA contacts according
to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser
Updated•25 years ago
|
Target Milestone: M5 → M9
Comment 3•25 years ago
|
||
This really should not be my responsibility. Does anyone care? If so, they
should do it themselves.
Of course people care. If not why would I have bothered to create the bug in the
first place? It's a performance problem
Comment 5•25 years ago
|
||
Comment 6•25 years ago
|
||
On a similar note, in a lot of places timers are being created when there is
nothing to actually do and it's wasting a lot of cpu time. I've attached a
small patch that will fix it in the viewer executable. In the case of that
program the timers don't run unless there's an animation actually running ( the
throbber, really ) or there's something being downloaded.
There's still a problem in the layout engine that is creating timers every 25 MS
which gets pretty painful. I'm not sure how to fix it but I think that someone
who knows the layout engine should have a look. It's being reset in
nsViewManager::SetFrameRate().
Updated•25 years ago
|
Target Milestone: M9 → M10
Assignee: vidur → shaver
Status: ASSIGNED → NEW
Target Milestone: M10 → M11
This is _so_ not vidur's bug. If nobody in gfx/widget/layout will fix it, I'll
find some patches to turn on repeating timers and slam them in myself.
It really is Vidur's bug, after all he did the timer implementation. And it's
not like we never had repeating timers; we've had them in every single shipping
product
Status: NEW → ASSIGNED
Fair enough, I guess. Vidur can't really fix this, because it needs someone to
hack on each of the widget/timer implmentations. I'll try to find people to do
that.
Updated•25 years ago
|
Target Milestone: M11 → M12
Comment 11•25 years ago
|
||
m12
Updated•25 years ago
|
Target Milestone: M12 → M14
Comment 12•25 years ago
|
||
m14. let me know if this has autommagically become available before.
Comment 13•25 years ago
|
||
Bulk add of "perf" to new keyword field. This will replace the [PERF] we were
using in the Status Summary field.
Comment 14•25 years ago
|
||
Repeating timers are now implemented for windows and unix in bug #22979.
There is also skeleton code for mac and others.
I think this should go in. This is the second time I've implemented repeating
timers in Gtk+, and it's badly needed.
Comment 15•25 years ago
|
||
Added me to CC.
Reporter | ||
Comment 16•25 years ago
|
||
I think it should go in, too
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → DUPLICATE
This is a dup of 22979, really, and there's no point keeping it open.
*** This bug has been marked as a duplicate of 22979 ***
Updated•25 years ago
|
Status: RESOLVED → REOPENED
OS: Windows NT → Mac System 8.5
Hardware: PC → Macintosh
Summary: No repeating timers → [PP]Implement repeating, prioritised timers on Mac
Comment 18•25 years ago
|
||
Actually, after 22979 has been fixed there is still a need to get the new timer
features implemented on Mac. Reopening bug, so this task can be assigned to
a Mac person.
Comment 19•25 years ago
|
||
Clearing DUPLICATE resolution due to reopen.
Assignee | ||
Updated•25 years ago
|
Assignee: shaver → sfraser
Status: REOPENED → NEW
Assignee | ||
Comment 20•25 years ago
|
||
obligatory comment
Comment 21•25 years ago
|
||
removing vestigial tags, putting on beta1 radar per beta criteria priority #2.
Can anyone comment on how much affect this has on the Mac's glacial performance?
Keywords: beta1
Whiteboard: [Perf]
Comment 22•25 years ago
|
||
cc'ing waterson
Assignee | ||
Comment 23•25 years ago
|
||
Comment 24•25 years ago
|
||
sweet jesus, what does this bug mean, and who is going to do the work?
Assignee | ||
Comment 25•25 years ago
|
||
I know what the bug means, chris, and i can do the work. Most of the code can be
cloned from the windows implementation.
Comment 26•25 years ago
|
||
Putting on PDT- radar for beta1. Would like to get in, but would not hold beta
for this.
Whiteboard: [PDT-]
Updated•25 years ago
|
Summary: [PP]Implement repeating, prioritised timers on Mac → Implement repeating, prioritised timers on Mac
Assignee | ||
Updated•25 years ago
|
Whiteboard: [PDT-] → [PDT-] Fix in hand
Assignee | ||
Comment 28•25 years ago
|
||
I checked in an implementation of repeating/prioritized timers for the Mac.
Status: NEW → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•