Closed Bug 904 Opened 26 years ago Closed 25 years ago

Implement repeating, prioritised timers on Mac

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P2)

PowerPC
Mac System 8.5
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: troy, Assigned: sfraser_bugs)

References

Details

(Keywords: perf, platform-parity, Whiteboard: [PDT-] Fix in hand)

Attachments

(2 files)

The timer API and implementation doesn't support repeating timers, and this causes a large number of temporary timer objects to be created and destroyed; e.g., view mgr, throbber, image system services
Status: NEW → ASSIGNED
Setting all current Open Critical and Major to M3
per leger, assigning QA contacts to all open bugs without QA contacts according to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser
Target Milestone: M3 → M5
Target Milestone: M5 → M9
This really should not be my responsibility. Does anyone care? If so, they should do it themselves.
Of course people care. If not why would I have bothered to create the bug in the first place? It's a performance problem
On a similar note, in a lot of places timers are being created when there is nothing to actually do and it's wasting a lot of cpu time. I've attached a small patch that will fix it in the viewer executable. In the case of that program the timers don't run unless there's an animation actually running ( the throbber, really ) or there's something being downloaded. There's still a problem in the layout engine that is creating timers every 25 MS which gets pretty painful. I'm not sure how to fix it but I think that someone who knows the layout engine should have a look. It's being reset in nsViewManager::SetFrameRate().
Whiteboard: [Perf]
Putting on [Perf] radar
Blocks: 8691
Blocks: 9184
Target Milestone: M9 → M10
Assignee: vidur → shaver
Status: ASSIGNED → NEW
Target Milestone: M10 → M11
This is _so_ not vidur's bug. If nobody in gfx/widget/layout will fix it, I'll find some patches to turn on repeating timers and slam them in myself.
It really is Vidur's bug, after all he did the timer implementation. And it's not like we never had repeating timers; we've had them in every single shipping product
Fair enough, I guess. Vidur can't really fix this, because it needs someone to hack on each of the widget/timer implmentations. I'll try to find people to do that.
Target Milestone: M11 → M12
m12
Target Milestone: M12 → M14
m14. let me know if this has autommagically become available before.
Depends on: 22979
Keywords: perf
Bulk add of "perf" to new keyword field. This will replace the [PERF] we were using in the Status Summary field.
Repeating timers are now implemented for windows and unix in bug #22979. There is also skeleton code for mac and others. I think this should go in. This is the second time I've implemented repeating timers in Gtk+, and it's badly needed.
Added me to CC.
I think it should go in, too
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → DUPLICATE
This is a dup of 22979, really, and there's no point keeping it open. *** This bug has been marked as a duplicate of 22979 ***
Status: RESOLVED → REOPENED
OS: Windows NT → Mac System 8.5
Hardware: PC → Macintosh
Summary: No repeating timers → [PP]Implement repeating, prioritised timers on Mac
Actually, after 22979 has been fixed there is still a need to get the new timer features implemented on Mac. Reopening bug, so this task can be assigned to a Mac person.
Resolution: DUPLICATE → ---
Clearing DUPLICATE resolution due to reopen.
Assignee: shaver → sfraser
Status: REOPENED → NEW
obligatory comment
Keywords: pp
removing vestigial tags, putting on beta1 radar per beta criteria priority #2. Can anyone comment on how much affect this has on the Mac's glacial performance?
Keywords: beta1
Whiteboard: [Perf]
cc'ing waterson
Attached file irc log (deleted) —
sweet jesus, what does this bug mean, and who is going to do the work?
I know what the bug means, chris, and i can do the work. Most of the code can be cloned from the windows implementation.
Putting on PDT- radar for beta1. Would like to get in, but would not hold beta for this.
Whiteboard: [PDT-]
Summary: [PP]Implement repeating, prioritised timers on Mac → Implement repeating, prioritised timers on Mac
I'm not going to get to this by M14
Target Milestone: M14 → M15
Whiteboard: [PDT-] → [PDT-] Fix in hand
I checked in an implementation of repeating/prioritized timers for the Mac.
Status: NEW → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
QA contact updated
QA Contact: gerardok → madhur
verified on build 2001-07-24-07-trunk
Status: RESOLVED → VERIFIED
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: