Closed
Bug 908724
Opened 11 years ago
Closed 11 years ago
Avoid #including nsPresContext.h in nsIScrollableFrame.h
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
MatsPalmgren_bugz
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #794731 -
Flags: review?(matspal)
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Wrong patch
Attachment #794731 -
Attachment is obsolete: true
Attachment #794731 -
Flags: review?(matspal)
Attachment #794743 -
Flags: review?(matspal)
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Comment on attachment 794743 [details] [diff] [review]
Patch (v1)
Looks good. r=mats
A few nits you might want to fix while you're here:
>content/events/src/nsEventStateManager.cpp
>+ ScrollbarStyles overflowStyle =
>+ aScrollableFrame->GetScrollbarStyles();
It looks like this would fit on one line now.
>layout/forms/nsListControlFrame.cpp
>+ return ScrollbarStyles(NS_STYLE_OVERFLOW_HIDDEN,
>+ verticalStyle);
this too
>layout/base/ScrollbarStyles.h
>+struct ScrollbarStyles {
I know you just copy-pasted this, but { should go on its own line
>+ uint8_t mHorizontal, mVertical;
... and mVertical should be declared on its own line.
Attachment #794743 -
Flags: review?(matspal) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
Landed with the nits addressed: https://hg.mozilla.org/integration/mozilla-inbound/rev/5a9fb1ce1de5
|
||
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•