Closed Bug 90945 Opened 23 years ago Closed 23 years ago

Do UI for Strict Javascript and dump() prefs

Categories

(SeaMonkey :: UI Design, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.3

People

(Reporter: gerv, Assigned: gerv)

Details

Attachments

(3 files)

I can't be the only person who keeps forgetting the prefs to turn on strict JS and the dump() command. We should add UI for these to the Debug preferences panel. Patch coming up - looking for r= and a rubberstamp. Gerv
Attached patch Patch v.1 (deleted) — Splinter Review
You probably need someone's approval (possibly Ben's) before checking in... but the code looks good to me - assuming the additional changes you've made are all whitespace changes (can we get a -uw please?). r=hwaara
r=bzbarsky
Keywords: approval, patch
Gervase Markham wrote: > - <checkbox id="showAboutAsStupidModalWindow" label="&debugShowAboutAsStupidModalWindow.label;" > + <checkbox id="showAboutAsStupidModalWindow" label="&debugShowAboutAsModal.label;" > pref="true" preftype="bool" prefstring="browser.show_about_as_stupid_modal_window" > prefattribute="checked"/> Why did you rename the entity to remove "Stupid" and "Window"?
Why not? :-) Because it was stupidly long and made it harder to format the files. Ben? Blake? Are you cool with this? Gerv
Thank god. Yes, I'm very cool with this, I keep forgetting this pref. Feel like removing the personal toolbar dnd option while you're there (it should always be on now)?
don't pieces of DnD not work on macos and unix?
r=bzbarsky for patch v.3
I'd like to get this in 0.9.3; I've emailed blake for sr=. Gerv
JavaScript is spelled "JavaScript" not "Javascript" !
I'll fix it :-) Still looking for sr=. Gerv
Target Milestone: --- → mozilla0.9.3
Can we change that "Strict Javascript checking" text to something more clear, like "Show strict Javascript warnings"? sr=blake
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Checked in. Gerv
vrfy fixed: changes look good in the General Debug pref panel. linux, 2001.08.15.14-comm winnt, 2001.08.15.06-comm mac OS 9.1 [emul on X], 2001.08.15.08-comm
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: