Closed
Bug 912700
Opened 11 years ago
Closed 10 years ago
Audit all uses of FrameMetrics::mViewport for correctness and consistency
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file)
(deleted),
patch
|
botond
:
review+
|
Details | Diff | Splinter Review |
Along with mCompositionBounds, mViewport is the other poorly-defined field in FrameMetrics. Actually, it's defined reasonably enough, but uses of it are inconsistent. mViewport is supposed to be the CSS viewport of the document, which means that (a) it should only be valid for the layers that correspond to documents and (b) could be affected by meta viewport tags on the document in question, so may not be the same as the visible rect or composition bounds of the frame.
Looking at the uses of mViewport [1] shows that a bunch of pieces of code conflate this field with the composition bounds and will need to be fixed up.
[1] http://dxr.mozilla.org/mozilla-central/search?q=%2Bvar-ref%3Amozilla%3A%3Alayers%3A%3AFrameMetrics%3A%3AmViewport
Assignee | ||
Updated•11 years ago
|
Component: Graphics: Layers → Panning and Zooming
Assignee | ||
Updated•11 years ago
|
No longer blocks: multi-apzc
Assignee | ||
Comment 1•10 years ago
|
||
Bug 1056427 removes some uses of mViewport that appear totally bogus.
Depends on: 1056427
Assignee | ||
Comment 2•10 years ago
|
||
And I audited all the rest and they look good. Also wrapped them in a getter/setter while I was at it.
Assignee: nobody → bugmail.mozilla
Attachment #8476667 -
Flags: review?(botond)
Updated•10 years ago
|
Attachment #8476667 -
Flags: review?(botond) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Comment 4•10 years ago
|
||
Comment 6•10 years ago
|
||
Sorry about that, I had just pulled and was trying to test the try chooser extension so your rev was at the top of my queue.
Flags: needinfo?(mmc)
Comment 7•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•