Closed
Bug 913374
Opened 11 years ago
Closed 11 years ago
[B2G] [Bluetooth] Use nsRefPtr for BluetoothProfileController in profile managers
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(blocking-b2g:koi+, firefox25 wontfix, firefox26 fixed, firefox27 fixed, b2g-v1.2 fixed)
People
(Reporter: gyeh, Assigned: gyeh)
References
Details
(Whiteboard: [u=devices c=BT p=5] )
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → gyeh
|
|
Assignee | |
Comment 1•11 years ago
|
||
Eric, please review this patch. Thanks.
Attachment #810919 -
Flags: review?(echou)
|
||
Updated•11 years ago
|
Target Milestone: --- → 1.2 QE1(Oct11)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 810919 [details] [diff] [review]
Patch 1(v1): Use nsRefPtr for BluetoothProfileController
Review of attachment 810919 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with nits addressed.
::: dom/bluetooth/BluetoothProfileController.h
@@ +60,5 @@
> public:
> BluetoothProfileController(const nsAString& aDeviceAddress,
> BluetoothReplyRunnable* aRunnable,
> BluetoothProfileControllerCallback aCallback);
> + virtual ~BluetoothProfileController();
Why virtual?
::: dom/bluetooth/linux/BluetoothDBusService.cpp
@@ +176,5 @@
> static nsString sAdapterPath;
> static Atomic<int32_t> sIsPairing(0);
> static int sConnectedDeviceCount = 0;
> static StaticAutoPtr<Monitor> sStopBluetoothMonitor;
> +nsRefPtr<BluetoothProfileController> sController;
StaticRefPtr should be used for this case.
Attachment #810919 -
Flags: review?(echou) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Good point! Thanks.
|
|
Assignee | |
Comment 4•11 years ago
|
||
try:
https://tbpl.mozilla.org/?tree=Try&rev=b8925633ad29
https://tbpl.mozilla.org/?tree=Try&rev=85b6d7739a3e
Attachment #810919 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Comment 7•11 years ago
|
||
status-b2g-v1.2:
--- → fixed
status-firefox25:
--- → wontfix
status-firefox26:
--- → fixed
status-firefox27:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•