Closed
Bug 913851
Opened 11 years ago
Closed 11 years ago
Minimize the #includes in js/xpconnect
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
|
(deleted),
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
Attachment #801149 -
Flags: review?(bobbyholley+bmo)
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
|
Assignee | |
Comment 5•11 years ago
|
||
I think the Windows link error was because of a class/struct mismatch. Hopefully this patch fixes it:
https://tbpl.mozilla.org/?tree=Try&rev=2fc3f8379b22
|
||
Comment 6•11 years ago
|
||
Comment on attachment 801149 [details] [diff] [review]
Patch (v1)
Review of attachment 801149 [details] [diff] [review]:
-----------------------------------------------------------------
\o/
Was this done with IWYU or some similarly-automated tool? I sure hope so. :-)
Attachment #801149 -
Flags: review?(bobbyholley+bmo) → review+
|
|
Assignee | |
Comment 7•11 years ago
|
||
(In reply to Bobby Holley (:bholley) from comment #6)
> Was this done with IWYU or some similarly-automated tool? I sure hope so. :-)
Yeah, I'm using IWYU for all of this stuff. I'm not as awesome as I'd like to make it look like. ;-)
|
|
Assignee | |
Comment 8•11 years ago
|
||
My patch bitrotted :(
https://tbpl.mozilla.org/?tree=Try&rev=ce277a9c3f79
|
|
Assignee | |
Comment 9•11 years ago
|
||
|
||
Comment 10•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•