running ./flash.sh gaia on a hamachi device sometimes breaks things. :nhirata and :mwu worked out a script that flashes gaia correctly for the hamachi. let's modify the main flash.sh script so that it does things correctly.

here's the bug for modifying ./flash.sh to do the gaia flash correctly for hamachi devices.

The fullflash script is something that mwu and I spent time troubleshooting to get gaia to flash and work at the end. We would want to take the gaia flashing part from this and apply it to the flash script.

Found out there's no need to use the stuff in the fullflash script. A quick change to do reset-gaia should do the trick. I did a test to make sure it works. Having said that, I think we need to follow up and figure out why install-gaia is having issues. Filed bug 915484

Hmm, this would destroy data, which is a bit scary but probably acceptable. I think the core problem is that gaia flashes to /data by default, but normal builds (like vendor builds) always puts gaia in /system. If gaia is installed to both places, things break. The ideal solution would probably be to always install gaia to /system by default. Do gaia developers need to install to /data?

Assigning this to Naoki since he's working on it. Naoki, the ball is in your court.

My flashing script in [1] finds if my device is in production or in eng mode, and will flash in the correct location. Might be a good idea to do this in our build system ? [1] https://github.com/julienw/config-files/blob/master/gf

(In reply to Julien Wajsberg [:julienw] from comment #6) > My flashing script in [1] finds if my device is in production or in eng > mode, and will flash in the correct location. > > Might be a good idea to do this in our build system ? > > [1] https://github.com/julienw/config-files/blob/master/gf Just doing the right thing is definitely preferred here. It looks like your script does the right thing, from a quick glance. Anybody want to put that logic in the gaia flash code? Putting it in gaia makes it work for people flashing from either flash.sh or the gaia directory.

The important bit is [1] [1] https://github.com/julienw/config-files/blob/master/gf#L69-L71

Whoa, Julien. Thanks for the script... I'll look at both and see if I can fix it up tonight if no one else gets to it today.

julienw, did you want me to merge the optimize and the other stuff? I can do that, I think we should file a separate bug. mwu, I squashed stuff down, and I think I'm ready for a review.

Pr : https://github.com/mozilla-b2g/B2G/pull/275

I removed the production=1 as it wasn't needed for the flash.sh; (I had pulled all the production=1 stuff into one if from julien's script) I gave it a quick test again just to be certain for a production and dev version of gaia (flash.sh gaia) just to be certain. Both worked as expected.

Comment on attachment 803434 [details] 275.html This logic belongs on the gaia side, but this is better than before and hacking a shell script into makefiles is a bit awkward.

Pushed to B2G/master: https://github.com/mozilla-b2g/B2G/commit/9b073c720960c39820a4fd7e44a394171c060a41

I'll relook at putting the logic into the Makefile in gaia instead in Bug 915484