Noticed this happening a couple of times today on all locales and all platforms with Nightly 26 26.0a1 (20130911030258). Sample report: http://mozmill-daily.blargon7.com/#/functional/report/26d5854914a68aa13b333f2815a5de00

I manage to reproduce this manually and it seems to be a regression. Steps to reproduce: 1. Open AMO (Ctrl Shit A) 2. Disable any addon (we used Test Extensions as per our tests) 3. Click the 'Restart now button' Expected results: - The addon is disabled and it's 'active' attribute is false Actual results: - The 'Restat Now' button is still present and the addon enabled - The 'active' attribute is 'true' This happens even if we continue to restart the addon by using the 'Restart Now' button. I will add a skip patch soon.

Kyle, bug 888347 introduced a regression. Follow the steps to reproduce: 1. Open the latest Nightly build 2. Go to the Addons Manager page (Cmd/Ctrl + Shift + A) 3. Click on Extensions 4. Install an Addon that requires restart (search for 'youtube' and install the first item '1-Click YouTube Video Downloader 2.1.4' 5. Click on 'Restart now' 6. After Firefox Restarts, go back to the Addons Manager / Extensions page, the newly installed addon is Enabled 7. Click on Disable, a message requiring a restart appears, click on Restart Now (or manually restart Firefox) Expected results: The Addon should be in a disbaled state now Actual results: The Addon is in the same state, enabled and requiring a restart

Skip patch for default

From bug 905170 comment 19: > Regressor is bug 888347 > Changeset: http://hg.mozilla.org/integration/mozilla-inbound/rev/efc4235dd32d

Sounds like an addon manager bug was exposed. Does it use workers (or something that uses workers, like OS.file)?

Could this be related to bug 911820?

Yeah, I bet it is.

Comment on attachment 803061 [details] [diff] [review] skip.patch Review of attachment 803061 [details] [diff] [review]: ----------------------------------------------------------------- The skip message could have been more specific, but lets get this skipped. Landed: http://hg.mozilla.org/qa/mozmill-tests/rev/4fa131f1e7b7 (default)

We unskipped the tests and ran them with the latest Nightly build to check that all works alright. I think it's safe to unskip Bugs 905170, 905193, 909237 and 915193. Reports: Linux: http://mozmill-crowd.blargon7.com/#/functional/report/dc3d4d2f66af31b9e75e291fa0e06dcf http://mozmill-crowd.blargon7.com/#/functional/report/dc3d4d2f66af31b9e75e291fa0dd726a http://mozmill-crowd.blargon7.com/#/functional/report/dc3d4d2f66af31b9e75e291fa0deb353 Windows: http://mozmill-crowd.blargon7.com/#/functional/report/dc3d4d2f66af31b9e75e291fa0e00107 http://mozmill-crowd.blargon7.com/#/functional/report/dc3d4d2f66af31b9e75e291fa0da47db http://mozmill-crowd.blargon7.com/#/functional/report/dc3d4d2f66af31b9e75e291fa0dce28a Mac: http://mozmill-crowd.blargon7.com/#/functional/report/dc3d4d2f66af31b9e75e291fa0daf089 http://mozmill-crowd.blargon7.com/#/functional/report/dc3d4d2f66af31b9e75e291fa0d9e2ad

Comment on attachment 806007 [details] [diff] [review] unskip_DEFAULT.patch Review of attachment 806007 [details] [diff] [review]: ----------------------------------------------------------------- Landed: http://hg.mozilla.org/qa/mozmill-tests/rev/42fa281bdd21 (default) Thanks!

Fixed by bug 911621.