1. run make install-gaia Expected: booted into new gaia with fresh profile Actual: still stuck at the logo Follow up bug to bug 15034

correction : bug 915034

Bug 915034 temp fixes the flash.sh to include the logic for checking which directory to install the files. Using this one to place the fix into the gaia/Makefile

I was quite busy this week but I can probably help you here next week or after the summit.

Julien, this is as far as I got since last week: https://github.com/mozilla-b2g/gaia/pull/12764 I think the -q flag in the grep is causing it to not work correctly the info is to print the output of the Makefile. I will try to work on it some more this week. If you have any suggestions please let me know.

I think I figured it out. Should I remove the logic from the flash.sh after filing a bug on that?

Hmm, that should be set only if it isn't set already (it can be imported from .b2g.mk). It also needs to account for running make targets that don't require a device to be plugged in (like make profile).

I agree, probably we need to do all the GAIA_INSTALL_PARENT stuff inside the install-gaia target. But then we need to run all lines in the same shell and finish all lines with "&& \". So maybe it would be a better idea to move the "install-gaia" target commands in an external file...

This is something worthy to be worked on after bug 997029. I propose we make GAIA_INSTALL_PARENT default to empty string (instead of |/system/b2g|), and run adb to determine the best place to put the apps if it is not specified externally, or with other parameters.

see [1] for the code I use to determine GAIA_INSTALL_PARENT from a plugged in device. This code is also partly used in the flash.sh script in the B2G repository thanks to Naoki. [1] https://github.com/julienw/config-files/blob/master/gf#L69-L78

Yes, that's what I intend to include in Makefile.

Comment on attachment 8408894 [details] mozilla-b2g:master PR#18450 I ended up patch the push-to-device.js file instead of Makefile to stop dumping more logic there. As suggested by :felash, |make push| will read back /data/local/webapps/webapps.json to see what's the correct webapps locations, if GAIA_INSTALL_PARENT is not set. One exception is |make reset-gaia|. Given the fact webapps.json is removed at the |purge| step before |push|, it's default location should be /system/b2g, to keep the original behavior. Additional clean-up in this patch makes specifying $ADB work, and nicer console output.

Comment on attachment 8408894 [details] mozilla-b2g:master PR#18450 works for me but I added some suggestions about how to do in IMO a cleaner way the reset-gaia case. Also, I'd like that we stop using predictable temporary file names in the gaia directory.

try server: https://tbpl.mozilla.org/?tree=Try&rev=bda6c777e297

Comment on attachment 8408894 [details] mozilla-b2g:master PR#18450 Tim, I left comments on github and please set me review flag again if pull request is updated. BTW, please test this pull request on Windows, it looks a little bit danger for Windows.

Comment on attachment 8408894 [details] mozilla-b2g:master PR#18450 Addressing review comment and moving most of the logic to JS.

Comment on attachment 8408894 [details] mozilla-b2g:master PR#18450 added some comments, nothing blocking from my point of view, but would be nice to handle. I didn't try the patch, please tell me if you would like that I try it.

Hi Alex, could you help to review this pr? I will not avaiable next week.

Comment on attachment 8408894 [details] mozilla-b2g:master PR#18450 Some suggestions in the PR, but that looks good. Speaking about Windows support, master fails for me with: Exception: Error: it does not support sh.exe command I get the exact same error with this patch. Filled bug 1002461. If I fix it, I end up with a broken gaia with what looks like a homescreen but with no app icon at all. Again, I end up in the same state with your patch or master.

Need to fix test breakage...

master: https://github.com/mozilla-b2g/gaia/commit/edc0b4ade03fc9d5596093092accce5b9c59f83b