Closed
Bug 916912
Opened 11 years ago
Closed 11 years ago
IonMonkey: convert away from void* usage
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: luke, Assigned: luke)
References
Details
Attachments
(4 files)
(deleted),
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
This bug sweeps up some of the cases remaining after bug 914814 that don't use ImmPtr for embedding pointers in generated code.
Assignee | ||
Comment 1•11 years ago
|
||
Rather than switching to ImmPtr (which will require special treatment to in bug 900669), this patch removes loadStatic(Double|Float), replacing them with loadConstant(Double|Float). This should generate equivalent code with the only difference being slightly more memory to store the double/float (which seems negligible).
Attachment #805464 -
Flags: review?(jdemooij)
Assignee | ||
Comment 2•11 years ago
|
||
In one other case, we load from static doubles for the operand to an add. This patch adds an addConstant(Double|Float) to achieve the same effect.
Attachment #805465 -
Flags: review?(jdemooij)
Assignee | ||
Comment 3•11 years ago
|
||
This patch removes the void*-taking overload of Operand (requiring instead Operand(AbsoluteAddress(ptr)). Several of these cases involve generating loads from an address that is patched in later. Since this is fine for serialization (the patching will also happen after deserialization), I introduced a new PatchedAbsoluteAddress. The key distinction is that, while AbsoluteAddress/ImmPtr will JS_ASSERT(!IsCompilingAsmJS()), PatchedAbsoluteAddress won't.
Attachment #805469 -
Flags: review?(jdemooij)
Updated•11 years ago
|
Attachment #805464 -
Flags: review?(jdemooij) → review+
Updated•11 years ago
|
Attachment #805465 -
Flags: review?(jdemooij) → review+
Updated•11 years ago
|
Attachment #805469 -
Flags: review?(jdemooij) → review+
Assignee | ||
Comment 4•11 years ago
|
||
This patch (I think the last one) switches j/addPendingJump to use ImmPtr.
Attachment #806060 -
Flags: review?(jdemooij)
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa389e608d2a
https://hg.mozilla.org/integration/mozilla-inbound/rev/53edc4194eb3
https://hg.mozilla.org/integration/mozilla-inbound/rev/e482e83c5e88
Whiteboard: [leave open]
Comment 6•11 years ago
|
||
Updated•11 years ago
|
Attachment #806060 -
Flags: review?(jdemooij) → review+
Assignee | ||
Comment 7•11 years ago
|
||
Whiteboard: [leave open]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•