Closed
Bug 919703
Opened 11 years ago
Closed 11 years ago
Make search/replace and goto UX more Firefox-ey
Categories
(DevTools :: Source Editor, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: anton, Assigned: anton)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
anton
:
review+
|
Details | Diff | Splinter Review |
Currently, we use CodeMirror's default UI which clashes a bit with Firefox UI.
|
Assignee | |
Updated•11 years ago
|
Priority: P3 → P2
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → anton
|
|
Assignee | |
Comment 4•11 years ago
|
||
This patch adds a couple of CSS rules to make dialogs more devtoolsey. Heather reviewed this patch on my computer.
Attachment #8335664 -
Flags: review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
|
||
Comment 7•11 years ago
|
||
This should bug should be left opened since the patch is WIP and this isn't the final design yet.
|
|
||
Comment 8•11 years ago
|
||
I found a few issues :
The height between the toolbar and the code mirror "dialog" isn't consistent
The code mirror "dialog" has an ugly white border (mostly visible in dark theme)
|
|
Assignee | |
Comment 9•11 years ago
|
||
This patch is not WIP, there's no "final design" because there's no designer working on that. If shorlander comes up with a different design, there will be a new bug.
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•