If you change a sidebar's url from it's first value to another value, then back to the original value, that fails at the moment with this error: "Creating two sidebars with the same title + url is not allowed"

Pointer to Github pull-request

Comment on attachment 813416 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1258 r+ with the comments in PR addressed.

Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/1f225644b37610f6d516cddaaf4989708f661e22 Bug 923348 - Changing a sidebar.url from A to B then back to A does not work https://github.com/mozilla/addon-sdk/commit/ae52323a0c46c3b42aa67ea0cc95234dac29e4e4 Merge pull request #1258 from erikvold/923348 Bug 923348 - Changing a sidebar.url from A to B then back to A does not work r=@zer0

Comment on attachment 813416 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1258 [Approval Request Comment] User impact if declined: A new Jetpack api will throw errors in what may be a typical use case. Testing completed (on m-c, etc.): yes Risk to taking this patch (and alternatives if risky): Low/No risk

How does this work? Is there something to land to mozilla-central? It's not clear what I'm approving Aurora uplift for when the pull requests are all in github.

Dave can you answer Lukas ?

(In reply to lsblakk@mozilla.com [:lsblakk] from comment #5) > How does this work? Is there something to land to mozilla-central? It's > not clear what I'm approving Aurora uplift for when the pull requests are > all in github. We'll manually take the patch from https://github.com/mozilla/addon-sdk/pull/1258/files and apply it to the addon-sdk directory of the aurora branch. Sorry that that's not clear. We can just upload the patch as an attachment in the future if that is more helpful?

(In reply to Dave Townsend (:Mossop) from comment #7) > We'll manually take the patch from > https://github.com/mozilla/addon-sdk/pull/1258/files and apply it to the > addon-sdk directory of the aurora branch. Sorry that that's not clear. We > can just upload the patch as an attachment in the future if that is more > helpful? Sorry if I'm missing something here - but will that manual patch also get applied to mozilla-central? Is there a new way of doing addon-sdk integration where we don't ensure that later versions are matched up with code landings?

Comment on attachment 813416 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1258 Sorry, it seems that our normally weekly process for uplifting all our code to m-c hasn't happened in a couple of weeks. I'll find out why, get this all uplifted then we can talk about approvals.

This landed in m-c three days ago so we would now like to get approval for aurora and beta. [Approval Request Comment] Bug caused by (feature/regressing bug #): New feature - sidebars API User impact if declined: Feature will be broken in some cases Testing completed (on m-c, etc.): 3 days testing, very few add-ons using this yet though Risk to taking this patch (and alternatives if risky): Very low risk, alternative would be removing sidebar feature entirely

Comment on attachment 829483 [details] [diff] [review] patch If you don't mind throwing in the changeset link for m-c when you put in the ones for aurora/beta that would be great for posterity.

http://hg.mozilla.org/mozilla-central/rev/f4fdb40f96b1 https://hg.mozilla.org/releases/mozilla-aurora/rev/74cf83afd3ca https://hg.mozilla.org/releases/mozilla-beta/rev/851face56dbe