Closed
Bug 925140
Opened 11 years ago
Closed 11 years ago
Remove unnecessary nsAlgorithm.h includes from gfx/2d
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
(deleted),
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
Two chromium-derived .cpp files in gfx/2d/ have #includes for nsAlgorithm.h, for no apparent reason. (It might possibly be because we used to support VC9, which needed nsAlgorithm's "std::abs()" definition, but that's not relevant anymore because we don't support VC9 anymore, and I'm ripping out that abs() definition in bug 925129.)
Anyway, we should drop this nsAlgorithm.h include, since it's not needed and it'll make for less xpcom headers and #defines influencing gfx/2d* which is a win (since it saves us from stuff like bug 924768).
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 815122 [details] [diff] [review]
fix v1
Actually, looks like Jeff's on vacation. tn, looks like you've touched these files; mind reviewing?
Attachment #815122 -
Flags: review?(jmuizelaar) → review?(tnikkel)
Updated•11 years ago
|
Attachment #815122 -
Flags: review?(tnikkel) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Flags: in-testsuite-
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•