johns made me notice that in bug 899080 i missed using a common setTestPluginEnabledState() function in at content/, searching through dxr more exhaustively i think those are the last tests that need clean-up for this: content/base/test/test_mixed_content_blocker.html content/base/test/test_object.html content/base/test/chrome/test_bug391728.html dom/plugins/test/mochitest/test_idle_hang.xul toolkit/mozapps/extensions/test/browser/browser_CTP_plugins.js widget/tests/test_plugin_input_event.html widget/tests/test_plugin_scroll_consistency.html widget/tests/test_plugin_scroll_invalidation.html

Comment on attachment 8377128 [details] [diff] [review] Cleanup, content/ Not super nice to have same functions defined many times, but I blame the one who started to add head.js for the first place. s/it's/its/

Try uncovered inter-bug-issues again, new push: https://tbpl.mozilla.org/?tree=Try&rev=7351d1052647

More interbug dependencies, new try push: https://tbpl.mozilla.org/?tree=Try&rev=954c3724d7aa

Comment on attachment 8377539 [details] [diff] [review] Cleanup, toolkit/, v2 The try run is looking good now. bsmedberg, can you review this part?

Comment on attachment 8377544 [details] [diff] [review] Cleanup, layout/ This fixes another intertest-dependency, the patch queue looks fine now on try.

Comment on attachment 8377719 [details] [diff] [review] Cleanup, content/, v3 The patch queue looks good on try now with additional test changes in content/, sorry about the double request.

https://hg.mozilla.org/integration/mozilla-inbound/rev/97c8c8491b17 https://hg.mozilla.org/integration/mozilla-inbound/rev/18f6689b172d https://hg.mozilla.org/integration/mozilla-inbound/rev/44dbd2276837 https://hg.mozilla.org/integration/mozilla-inbound/rev/f2cade11e3c0 https://hg.mozilla.org/integration/mozilla-inbound/rev/9112c3abc3ea

had to backout this changes since tbpl reported leaks in testruns like https://tbpl.mozilla.org/php/getParsedLog.php?id=35040337&tree=Mozilla-Inbound

I'd rather over-estimate this for possibly mysterious leak investigations.

I took the original cleanup for widget/tests/ and added support for 2 additional tests (both mochitest-chrome tests: test_imestate.html and test_chrome_context_menus_win.html). These pass locally as well as on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=acaae2f68e4c I did retriggers on the oth and m-5 runs and no leaks are showing up.

Comment on attachment 8546602 [details] [diff] [review] cleanup widget/tests/* (2.0) Great to hear, thanks for picking this up :)