Closed
Bug 927544
Opened 11 years ago
Closed 11 years ago
Call unknown method hooks in Ion callprop VM calls
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
The stub call made when Ion deoptimizes a JSOP_CALLPROP does not invoke unknown method hooks on the object.
Attachment #817999 -
Flags: review?(jdemooij)
|
||
Updated•11 years ago
|
Attachment #817999 -
Flags: review?(jdemooij) → review+
|
||
Comment 1•11 years ago
|
||
+ JS_ASSERT(op = JSOP_CALLPROP);
|
Assignee | |
Comment 2•11 years ago
|
||
(In reply to Maurício Collares Neto from comment #1)
> + JS_ASSERT(op = JSOP_CALLPROP);
Thanks, good catch.
I ended up folding this into the patch for bug 925962, rev 81b505e9a435. That rev inadvertently fixed the above bug, by using a different mechanism to distinguish calls vs. gets (weirdly, CallGetProperty isn't associated with a resume point when used to fetch the |prototype| property for callee functions).
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Assignee: nobody → bhackett1024
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•