secmod_FindExternalRoot calls SECMOD_AddNewModule a number of times expecting it to fail most of the time. However, SECMOD_AddNewModule leaks on failure. This results in a bunch of module arenas being leaked on startup in Mozilla. The following patch fixes the leak for me. Index: pk11util.c =================================================================== RCS file: /cvsroot/mozilla/security/nss/lib/pk11wrap/pk11util.c,v retrieving revision 1.7 diff -u -d -r1.7 pk11util.c --- pk11util.c 2001/02/06 00:11:24 1.7 +++ pk11util.c 2001/08/02 18:42:00 @@ -506,6 +506,7 @@ if (rv != SECSuccess) { /* SECFailure: failed to add module, corrupt or missing module etc. */ /* SECBlock: a module with the same name already exists */ + SECMOD_DestroyModule(module); return rv; } else { /* successfully added module */ /* turn on SSL cipher enable flags */

David, this bug is already fixed. The cvs tag on your mozilla/security/nss/lib/pk11wrap/pk11util.c should be NSS_CLIENT_TAG, revision 1.7.2.1. *** This bug has been marked as a duplicate of 78467 ***

Hmmm. That's what I get for using MOZ_NSS_AUTOCONF. I'm on the NSS_CLIENT_BRANCH.

I see. Don't set MOZ_NSS_AUTOCONF. It is an experimental build option and is not supported by the NSS team.