Closed
Bug 933493
Opened 11 years ago
Closed 11 years ago
Line height in Inspector and other developer tools should be consistent
Categories
(DevTools :: Source Editor, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: ntim, Assigned: paul)
References
Details
(Whiteboard: [good first verify])
Attachments
(2 files)
User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20131031030203
Steps to reproduce:
Open the dev-tools, compare the line-height in the Inspector and in the Style Editor (or Scratchpad).
Actual results:
The line height is different, I think a more spaced line height like in the Inspector is nice.
Expected results:
The line height should be equal
Reporter | ||
Updated•11 years ago
|
Component: Untriaged → Developer Tools: Framework
OS: Windows 8.1 → All
Hardware: x86_64 → All
Reporter | ||
Updated•11 years ago
|
Component: Developer Tools: Framework → Developer Tools: Source Editor
Comment 1•11 years ago
|
||
I don't see the issue. Could you please attach a screenshot ?
Updated•11 years ago
|
Flags: needinfo?(ntim007)
Comment 2•11 years ago
|
||
Inspector doesn't use the SourceEditor component to display its stuff so I can see how there might be differences. I'm not sure if this is an issue worth fixing though. And it definitely doesn't block CodeMirror meta bug.
Stephen, is this a big UX issue?
No longer blocks: 816756
Flags: needinfo?(shorlander)
Comment 3•11 years ago
|
||
The Scratchpad on the left is what CodeMirror currently looks like. It's far too squished to be comfortable for me (if you look closely, you can see the underscore and bracket markers in the selected line aren't even inside the line highlight).
The line height is set by this rule:
https://mxr.mozilla.org/mozilla-central/source/browser/devtools/sourceeditor/codemirror/codemirror.css#105
If you remove that rule (or override it with line-height:initial) then you get the Scratchpad on the right, which I'm far more comfortable with (and which is much closer to what we had before CodeMirror landed).
Comment 5•11 years ago
|
||
This was fixed in bug 941643.
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Flags: needinfo?(shorlander)
Resolution: --- → FIXED
Updated•11 years ago
|
Updated•11 years ago
|
Whiteboard: [good first verify]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•