Closed
Bug 934805
Opened 11 years ago
Closed 11 years ago
Ensure client code passes in sane additionalParts argument to baseDomain functions
Categories
(Core :: Networking: Domain Lists, defect)
Core
Networking: Domain Lists
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: jduell.mcbugs, Assigned: jduell.mcbugs)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
u408661
:
review+
|
Details | Diff | Splinter Review |
Passing negative values to nsIEffectiveTLDService:GetBaseDomain{FromHost} is {WRONG,EVIL,Generally a bug} and should fail early (so we don't hit issues like bug 822869 comment 64).
Try run (with patches from 822869, too):
https://tbpl.mozilla.org/?tree=Try&rev=084b7ed434d6
Attachment #827153 -
Flags: review?(hurley)
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → jduell.mcbugs
Attachment #827153 -
Attachment is obsolete: true
Attachment #827153 -
Flags: review?(hurley)
Attachment #827164 -
Flags: review?(hurley)
Comment on attachment 827164 [details] [diff] [review]
v2: now even less broken!
Review of attachment 827164 [details] [diff] [review]:
-----------------------------------------------------------------
Ugh, the mismatch between signedness of public and internal functions makes me feel less-than-good, but that ship sailed a while ago, and it's not your fault. r=me
Attachment #827164 -
Flags: review?(hurley) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 3•11 years ago
|
||
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in
before you can comment on or make changes to this bug.
Description
•