Closed
Bug 937572
Opened 11 years ago
Closed 11 years ago
[Bluetooth] MOZ_ASSERT fails in BluetoothOppManager::Disconnect() on debug build
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ben.tian, Assigned: ben.tian)
Details
(Keywords: regression)
Attachments
(1 file, 2 obsolete files)
This bug is regression of bug 897782. Disconnect() is still called internally in BluetoothOppManager. Need to implement socket disconnection for it.
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → btian
|
||
Updated•11 years ago
|
Keywords: regression
|
|
Assignee | |
Comment 2•11 years ago
|
||
Replace Disconnect() with socket disconnection directly.
Attachment #830772 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•11 years ago
|
Attachment #831215 -
Flags: review?(echou)
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 831215 [details] [diff] [review]
Patch 1 (v2): socket disconnection in OPP Disconnect()
Review of attachment 831215 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with the only problem solved.
::: dom/bluetooth/BluetoothOppManager.cpp
@@ +462,5 @@
>
> if (mIsServer) {
> mAbortFlag = true;
> } else {
> + MOZ_ASSERT(mSocket);
Because BluetoothOppManager::StopSendingFile() may be called accidentally from Gaia even when mSocket is invalid, it would be better to block this case instead of only assertion.
if (mIsServer) {
mAbortFlag = true;
} else if (mSocket) {
mSocket->Disconnect();
} else {
// Do nothing(warning, maybe?)
}
Attachment #831215 -
Flags: review?(echou) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Update based on review comment.
try server: https://tbpl.mozilla.org/?tree=Try&rev=54ea0c58f16c
Attachment #831215 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Comment 5•11 years ago
|
||
Keywords: checkin-needed
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•