Closed Bug 939344 Opened 11 years ago Closed 9 years ago

Add jshint dependency

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

For complete integration with our developers, jshint needs to be added to the tree and set as a build dependency for Fennec. In the jshint distribution [1], there appears to be a rhino version, as well as a generic .js version. There are also nodejs distributions of jshint. We probably want to avoid these other external dependencies, however - perhaps we can use built-in interpreters (such as jsc on OS X). I have heard that the devtools team uses jshint in their development so we should ask them what they do (though [2] implies that it's not a requirement). Note also that this would require the jshint license to be compatible with what we use. [1]: https://github.com/jshint/jshint/tree/2.x/dist [2]: https://wiki.mozilla.org/DevTools/Hacking#Checking_your_code_using_JSHint
jshint is distributed under the MIT license [1], so I believe it is okay to include in the tree. [1]: https://github.com/jshint/jshint#license
I think we already use the spidermonkey JS shell in the build process. We should just look into using it for jshint too.
gps mentioned in bug 939350 comment 3 that the dependency can temporarily be downloaded and stored in ~/.mozbuild/ via the build system, before it's added to the tree (presumably so we can try things out).
I think we're moving to eslint, ala Hello (bug 1170804).
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.