Closed Bug 939708 Opened 11 years ago Closed 11 years ago

Mutt test failure 'radiogroup.select is not a function' in mutt/tests/js/testElementsLib/testRadioButtons.js

Categories

(Testing Graveyard :: Mozmill, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: andrei, Assigned: andrei)

References

Details

(Keywords: regression, Whiteboard: [mozmill-2.0.1])

Attachments

(1 file)

Looks like a regression in Firefox. On an affected build opening the relevant chrome xul page chrome://mozmill/content/test/radio_buttons.xul throws the following XML error: > XML Parsing Error: undefined entity > Location: chrome://mozmill/content/test/radio_buttons.xul > Line Number 20, Column 5: <checkbox id="showWhenDownloading" > ----^ *You can only open this xul page if you open Firefox through mozmill > mozmill -b %binary% --manual Pushlog for mozilla-central: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b4143e04bea1&tochange=770de5942471
Ugh, on inbound this appears to have come from a merge from mozilla-central: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c5116411da65&tochange=442b47e9fb80 And the problematic xul file is identical in both a working and a failing FF build (this one: chrome://mozmill/content/test/radio_buttons.xul ) Maybe some XML parsing rules have changed. Still looking to find the relevant change in FF that triggers this
Found the issue: The following lines were removed from the dtd we are using (chrome://browser/locale/preferences/main.dtd): > <!ENTITY showWhenDownloading.label "Show the Downloads window when downloading a file"> > <!ENTITY showWhenDownloading.accesskey "D"> > <!ENTITY closeWhenDone.label "Close it when all downloads are finished"> > <!ENTITY closeWhenDone.accesskey "w">
Attached patch 1.patch (deleted) — Splinter Review
I took out the elements that have been removed from the dtd. (we didn't use them in any mutt test) The mutt test now passes. We are again all green
Assignee: nobody → andrei.eftimie
Status: NEW → ASSIGNED
Attachment #8333785 - Flags: review?(hskupin)
Attachment #8333785 - Flags: review?(dave.hunt)
Blocks: 899110
Comment on attachment 8333785 [details] [diff] [review] 1.patch Review of attachment 8333785 [details] [diff] [review]: ----------------------------------------------------------------- Checkboxes for a radio button test doesn't make sense. That's correct. Lets get them removed. Nice catch and investigation + fix! Thanks.
Attachment #8333785 - Flags: review?(hskupin)
Attachment #8333785 - Flags: review?(dave.hunt)
Attachment #8333785 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [mozmill-2.0.1]
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: