Closed
Bug 939758
Opened 11 years ago
Closed 11 years ago
Build gfx/gl in unified mode
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: bjacob, Assigned: bjacob)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8333820 -
Flags: review?(ehsan)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8333820 [details] [diff] [review]
Build gfx/gl in unified mode
Review of attachment 8333820 [details] [diff] [review]:
-----------------------------------------------------------------
Nice!
::: gfx/gl/moz.build
@@ +76,5 @@
> EXPORTS += ['SharedSurfaceGralloc.h']
>
> if gl_provider == 'CGL':
> + # Not currently possible to build .mm files in unified mode, and we have
> + # only one here anyway.
The first part of your sentence is false. :-) (See bug 938844.)
@@ +92,5 @@
> 'SharedSurfaceIO.cpp',
> ]
> +elif gl_provider == 'GLX':
> + # GLContextProviderGLX.cpp needs to be kept out of UNIFIED_SOURCES
> + # as it includes X11 headers with cause conflicts.
s/with/which/
Attachment #8333820 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Target Milestone: --- → mozilla28
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•