Closed Bug 940153 Opened 11 years ago Closed 11 years ago

Build dom/encoding in unified mode

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: mz_mhs-ctb, Assigned: mz_mhs-ctb)

References

(Depends on 1 open bug)

Details

(Whiteboard: [qa-])

Attachments

(1 file, 3 obsolete files)

(2nd) Patch for checkin. r=bzbarsky
(deleted), patch
Details | Diff | Splinter Review
No description provided.
Attached patch Patch (obsolete) (deleted) — — Splinter Review
Attachment #8334317 - Flags: review?(ehsan)
Attachment #8334317 - Flags: review?(bzbarsky)
Comment on attachment 8334317 [details] [diff] [review] Patch r=me
Attachment #8334317 - Flags: review?(bzbarsky) → review+
Comment on attachment 8334317 [details] [diff] [review] Patch Boris, you're fast!
Attachment #8334317 - Flags: review?(ehsan)
Attached patch Patch for checkin. r=bzbarsky (obsolete) (deleted) — — Splinter Review
Attachment #8334317 - Attachment is obsolete: true
Keywords: checkin-needed
Keywords: checkin-needed
This broke the build <https://tbpl.mozilla.org/php/getParsedLog.php?id=30762597&tree=Mozilla-Inbound> so I backed it out: <https://hg.mozilla.org/integration/mozilla-inbound/rev/fba76534d05e> It looks like your patch breaks these dependencies <http://mxr.mozilla.org/mozilla-central/source/dom/encoding/Makefile.in#7>. In other words, you've kind of been beaten by bug 939615.
Depends on: 939615
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #6) > This broke the build > <https://tbpl.mozilla.org/php/getParsedLog.php?id=30762597&tree=Mozilla- > Inbound> so I backed it out: > <https://hg.mozilla.org/integration/mozilla-inbound/rev/fba76534d05e> btw thanks Ehsan! Tree reopened now
Attached patch bug940153.patch (obsolete) (deleted) — — Splinter Review
This patch does not move EncodingUtils and FallbackEncoding to UNIFIED_SOURCES.
Attachment #8334332 - Attachment is obsolete: true
Attachment #8334518 - Flags: review?(bzbarsky)
Comment on attachment 8334518 [details] [diff] [review] bug940153.patch r=me
Attachment #8334518 - Flags: review?(bzbarsky) → review+
Attachment #8334518 - Attachment is obsolete: true
This should avoid the issues with those files.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5ce118a0b0b5 https://hg.mozilla.org/mozilla-central/rev/fe616b87fefe
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: