Closed Bug 940191 Opened 11 years ago Closed 11 years ago

Build dom/base in unified mode

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: bjacob, Assigned: bjacob)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 4 obsolete files)

Build dom/base in unified mode
(deleted), patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review
No description provided.
Attached patch Build dom/base in unified mode (obsolete) (deleted) — — Splinter Review
Attachment #8334327 - Flags: review?(ehsan)
Attached patch Build dom/base in unified mode (obsolete) (deleted) — — Splinter Review
Attachment #8334327 - Attachment is obsolete: true
Attachment #8334327 - Flags: review?(ehsan)
Attachment #8334329 - Flags: review?(ehsan)
Attached patch Build dom/base in unified mode (obsolete) (deleted) — — Splinter Review
Now verified to build on 3 platforms...
Attachment #8334329 - Attachment is obsolete: true
Attachment #8334329 - Flags: review?(ehsan)
Attachment #8334335 - Flags: review?(ehsan)
Comment on attachment 8334335 [details] [diff] [review] Build dom/base in unified mode Still getting linking errors, in fact.
Attachment #8334335 - Flags: review?(ehsan)
Wooah! My linking errors were about multiply defined symbols from ipc/glue/MessageChannel.cpp. That made no sense from here, as I'm only tweaking dom/base here. But there is a dom/base/MessageChannel.cpp file. And the UNIFIED_SOURCES build system was mistaking ipc/glue/MessageChannel.cpp for dom/base/MessageChannel.cpp.
Attached patch Build dom/base in unified mode (obsolete) (deleted) — — Splinter Review
Without MessageChannel.cpp, all is fine...
Attachment #8334335 - Attachment is obsolete: true
Attachment #8334346 - Flags: review?(ehsan)
Assignee: nobody → bjacob
Let's wait for bug 939580 and get MessageChannel.cpp in as well.
Depends on: 939580
Comment on attachment 8334346 [details] [diff] [review] Build dom/base in unified mode Review of attachment 8334346 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/base/DOMError.cpp @@ +6,5 @@ > > #include "mozilla/dom/DOMError.h" > #include "mozilla/dom/DOMErrorBinding.h" > #include "nsPIDOMWindow.h" > +#include "DOMException.h" You want mozilla/dom/DOMException.h. ::: dom/base/moz.build @@ +102,5 @@ > ] > > +SOURCES += [ > + 'MessageChannel.cpp', > +] See my comment. ::: dom/base/nsQueryContentEventResult.h @@ +3,5 @@ > * License, v. 2.0. If a copy of the MPL was not distributed with this > * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ > > +#ifndef mozilla_dom_nsQueryContentEventResult_h__ > +#define mozilla_dom_nsQueryContentEventResult_h__ No trailing underscores please.
Attachment #8334346 - Flags: review?(ehsan) → review-
I just landed bug 939580 on inbound.
Attached patch Build dom/base in unified mode (deleted) — — Splinter Review
Attachment #8334346 - Attachment is obsolete: true
Attachment #8334778 - Flags: review?(ehsan)
Comment on attachment 8334778 [details] [diff] [review] Build dom/base in unified mode Review of attachment 8334778 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/base/moz.build @@ +103,5 @@ > > +# these files couldn't be in UNIFIED_SOURCES for now for reasons given below: > +SOURCES += [ > + # MessageChannel.cpp collides with a like-named file in ipc/glue, until bug 939580 is fixed > + #'MessageChannel.cpp', Please remove this stale comment.
Attachment #8334778 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/d8cd50781edc
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: