Closed
Bug 940215
Opened 11 years ago
Closed 11 years ago
Build netwerk/cache2, ftp, and rtsp in unified mode
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
(deleted),
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
To build these directories in unified mode, I:
* Renamed nsFtpConnectionThread.cpp's NowInSeconds() to (the admittedly ambiguous name) GetFtpTime() to avoid a NowInSeconds() conflict with nsHttp.h. I renamed the function instead of using nsHttp.h's function because I didn't want netwerk/protocol/ftp to rely on the netwerk/protocol/http's header files.
* Fixed -Wsometimes-uninitialized warning in nsFtpControlConnection.cpp.
* Only compiled Mozilla's RTSP code in unified mode to avoid making changing to the third-party RTSP code we imported from Android.
Green Try build:
https://tbpl.mozilla.org/?tree=Try&rev=c89cc9b72444
Attachment #8334355 -
Flags: review?(mcmanus)
|
||
Updated•11 years ago
|
Attachment #8334355 -
Flags: review?(mcmanus) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Comment 3•11 years ago
|
||
Turns out that we can't build rtsp in unified mode because it forces NSPR logging (detected by bug 941854.)
I backed out that part: https://hg.mozilla.org/integration/mozilla-inbound/rev/a9edd6f12058
Blocks: 941854
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•