Many of the i18n converts duplicate common code, without sharing the same source files. For example, the following C++ classes appear in many different files in the tree: nsBasicEncoder nsEncoderSupport nsBasicDecoderSupport nsBufferDecoderSupport nsTableDecoderSupport nsMultiTableDecoderSupport nsOneByteDecoderSupport The problem with this is that since this code is duplicated in many different files, that code may have diverged. When we link the static build, the linker strips out all but one copy of the source, so, if the source has diverged, some calls may end up in a different implementation. The least that needs to happen here is that the common code is factored out into unique source files (so we know the code is identical across converters). Ideally, the code should be shared between converters by moving it into a shared, non-component DLL.

This affects all platforms.

The attached static build link warnings show how many of these duplicate symbol warnings there are from these classes.

nsTableEncoderSupport and nsMultiTableEncoderSupport should also be in the list.

not quite sure how to address this issue yet.

not quite sure how to address this issue yet. Is there a compilation flag we can test against static linking build?

Not yet. The Mac static build will land in the next week or so, and then you'll be able to set the static_build option.

reassigning per ftang's request

accepting and targeting post-0.9.4. Will clarify with ftang, whether this is acceptable...

>Ideally, the code should be shared between converters by moving it into a shared, >non-component DLL. ftang do you agree with such a change? If not, I'd try to consolidate the duplicate code into unique source files - the alternative solution suggested by sfraser.

looks like this won't happen in M096 time frame. Sfraser - how urgent is this, could you also possibly give me a hand with some intial redesign ideas?

jbetak's contract is up. Bulk move bugs to ftang

give it to nhotta nhotta- can you coach rchen to do this ?

Changing QA contact to bobj for now. Bob, please re-assign further as you see is appropriate.