Closed Bug 942989 Opened 11 years ago Closed 9 years ago

Lectio website does not work in Firefox for Android phone

Categories

(Web Compatibility :: Mobile, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kbrosnan, Unassigned, Mentored)

References

()

Details

(Whiteboard: [country-dk][sitewait])

Attachments

(2 files)

Attached image Screenshot of FxA (deleted) —
Clicking on the modul listings should expand. On Firefox for Android the box increases in size only slightly. Developer site http://macom.dk/publish/da/lectio.htm
Attached image Screenshot of Chrome (deleted) —
The problem is here in the following inline script: <script type="text/javascript"> $(document).ready(function () { $('body').delegate('.s2withlink', 'click', function () { var tt = $(this).find('.s2mobiltitle'); if (tt.length == 0) { var newDiv = $("<div />"); newDiv.attr('class', 's2mobiltitle'); newDiv.get(0).innerText = $(this)[0].title; newDiv.css('display', 'none'); $(this).append(newDiv); } $(this).parent().find('.s2mobiltitle').toggle(); return false; }); }); </script> More specifically, the div.s2mobiltitle elements are empty in Gecko-based browsers due to this line: newDiv.get(0).innerText = $(this)[0].title; We don't implement innerText. A little odd that they're using innerText directly, since they're using jQuery in the same function. Changing this to newDiv.text($(this)[0].title) will make this work everywhere* (as jQuery abstracts the differences between innerText and textContent for you. *Bonus points if they change it to newDiv.text(this.title) and avoid creating a new jQuery instance just to access a property on `this`.
Whiteboard: [country-dk][contactready]
To be contacted There is a support email for LectioSupport@macom.dk Michael Herold, Developer Manager, herold at macom.dk http://www.linkedin.com/in/herold
Whiteboard: [country-dk][contactready] → [country-dk][contactready] [mentor=kdubost]
Thanks for the analysis. Site contacted via support.
Thank you for contacting them :)
Whiteboard: [country-dk][contactready] [mentor=kdubost] → [country-dk][sitewait] [mentor=kdubost]
Mentor: kdubost
Whiteboard: [country-dk][sitewait] [mentor=kdubost] → [country-dk][sitewait]
Depends on: innertext
I think this has been fixed. In all places where they had innerText it seems to have been replaced by a combination of textContent and innerText. if (IsExplorer) { document.getElementById(SelectboxNS_LastDisplayID).innerText = ''; } else { document.getElementById(SelectboxNS_LastDisplayID).textContent = ''; } and if (IsExplorer) { document.getElementById(DisplayID).innerText = SelectboxNS_SearchStr; } else { document.getElementById(DisplayID).textContent = SelectboxNS_SearchStr; } and TOptionTxt = (IsExplorer ? CBox.options[i].innerText : CBox.options[i].textContent); and SelectboxNS_TimeOutCode = SelectboxNS_TimeOutCode + 'document.getElementById(\'' + DisplayID + '\').' + (IsExplorer ? 'innerText' : 'textContent') + ' = \'\';'; I'm not sure that testing the browser is a good thing for IE and its future version. It forces them to keep the code for the future.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Thanks Anders
I now get a more desktop-like page on this URL, also in Chrome. Perhaps they dropped the mobile-adapted version of their site?
Product: Tech Evangelism → Web Compatibility
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: