Closed
Bug 944347
Opened 11 years ago
Closed 11 years ago
Disable fluffling for 1.2
Categories
(Core :: Layout, defect, P2)
Core
Layout
Tracking
()
People
(Reporter: vingtetun, Assigned: vingtetun)
References
Details
Attachments
(1 file)
(deleted),
patch
|
gwagner
:
review+
|
Details | Diff | Splinter Review |
Fluffling has a few issues that have popped up late in the process. Let's disable it for 1.2 and keep fixing it for 1.3.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8339885 -
Flags: review?(fabrice)
Updated•11 years ago
|
Component: General → Layout
Product: Firefox OS → Core
Comment 2•11 years ago
|
||
Blocking+ - this is turning off a non-ready feature for 1.2.
blocking-b2g: koi? → koi+
Comment 3•11 years ago
|
||
Can we enable it in the browser?
Updated•11 years ago
|
Priority: -- → P2
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to Gregor Wagner [:gwagner] from comment #3)
> Can we enable it in the browser?
If we fix https://bugzilla.mozilla.org/show_bug.cgi?id=942246 and https://bugzilla.mozilla.org/show_bug.cgi?id=941712 we can enable it everywhere :)
Comment 5•11 years ago
|
||
Vivien, I assume you can land this once Fabrice OK's it.
Assignee: nobody → 21
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to Milan Sreckovic [:milan] from comment #5)
> Vivien, I assume you can land this once Fabrice OK's it.
Yep, just waiting for him to come back from unjustified vacations :)
Comment 7•11 years ago
|
||
Comment on attachment 8339885 [details] [diff] [review]
bug944347.patch
Review of attachment 8339885 [details] [diff] [review]:
-----------------------------------------------------------------
Lets land it.
Attachment #8339885 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 8•11 years ago
|
||
Just realized that I don't have any 1.2 branch on my laptop. Let's do a checking needed.
This stuff should not land on master but only on the branch.
Updated•11 years ago
|
status-b2g-v1.2:
--- → affected
status-firefox27:
--- → wontfix
Keywords: checkin-needed
Whiteboard: [checkin-needed-b2g26]
Comment 9•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/b5511620d028
Can you please make sure your future patches have commit information included? Thanks :)
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Whiteboard: [checkin-needed-b2g26]
Updated•11 years ago
|
Target Milestone: --- → 1.2 C6(Dec6)
Assignee | ||
Comment 10•11 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #9)
> https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/b5511620d028
>
> Can you please make sure your future patches have commit information
> included? Thanks :)
> https://developer.mozilla.org/en-US/docs/
> Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-
> in_for_me.3F
My bad. I own you a beer or any drink of your choice.
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•