Closed
Bug 944961
Opened 11 years ago
Closed 11 years ago
Build rdf in unified mode
Categories
(Core Graveyard :: RDF, defect)
Core Graveyard
RDF
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
(deleted),
patch
|
benjamin
:
review+
axel
:
feedback+
|
Details | Diff | Splinter Review |
To build rdf in unified mode, I moved some gLog static file variables to static class member variables and moved some NS_DEFINE_CIDs from static file variables to local variables (where the CIDs are usually only constructed and used once).
Attachment #8340734 -
Flags: review?(axel)
Comment 1•11 years ago
|
||
Comment on attachment 8340734 [details] [diff] [review]
unify-rdf.patch
Review of attachment 8340734 [details] [diff] [review]:
-----------------------------------------------------------------
I'd prefer Benjamin to do the real review here, it's been too long since I've done actual coding. I'm also following the thread in .platform, which tells me that I should probably know more about what that does to code to do a real review.
The only thing that looks mildly hot-path is the QI of the content sink, AFAICT.
Attachment #8340734 -
Flags: review?(benjamin)
Attachment #8340734 -
Flags: review?(axel)
Attachment #8340734 -
Flags: feedback+
Comment 2•11 years ago
|
||
Trevor has done something similar to this in bug 943023 which has not landed yet...
Updated•11 years ago
|
Attachment #8340734 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Comment 4•11 years ago
|
||
Assignee | ||
Comment 5•11 years ago
|
||
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•11 years ago
|
Whiteboard: [qa-]
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•