After landing the urlparsing branch there is some duplicate code in nsURLHelper.cpp. The Escape/Unescape stuff is copied in nsEscape.cpp which is part of xpcom. The code in nsURLHelper.h/cpp can be removed. Also it is no longer necessary to provide an IOservice to allow code outside of necko to use escaping/unescaping. It can now be directly called from everywhere.

Some comments: The old code in nsURLEscape was able to append to a given string. nsStdEscape now truncates the given string, nsAppendURLEscapedString had to be adapted accordingly. Because of the removed ioService the following files had to be adapted to call nsStdEscape/Unescape directly: nsHttpChannel.cpp nsExternalHelperAppService.cpp nsHTMLUtils.cpp nsMsgFolder.cpp nsMsgCompose.cpp nsParseMailbox.cpp Surely there is a better way to get the string as an argument into nsStdEscape/nsStdUnescape.

r/sr=me

Looks good - should save a number of getService() calls. Built and works on Mac. r=ccarlen

fix checked in