Closed
Bug 947984
Opened 11 years ago
Closed 11 years ago
Australis API: Don't require onViewHiding/onViewShowing to add class to view node
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 29
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
(Whiteboard: [Australis:P4][qa-])
Attachments
(1 file)
|
(deleted),
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/annotate/9f12a9fab080/browser/components/customizableui/src/CustomizableUI.jsm#l1068 requires these events. We should ensure that's not required as long as a valid viewId is passed (this is already required in normalizeWidget).
|
Assignee | |
Comment 1•11 years ago
|
||
normalizeWidget already ensures that the viewId property at least exist, and that is really the only thing we need here.
Attachment #8344742 -
Flags: review?(mconley)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8344742 [details] [diff] [review]
Australis' view widgets shouldn't require onViewShowing/onViewHiding event handlers,
Review of attachment 8344742 [details] [diff] [review]:
-----------------------------------------------------------------
Yep, I'm fine with this. Thanks Gijs.
Attachment #8344742 -
Flags: review?(mconley) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Status: NEW → ASSIGNED
Whiteboard: [Australis:P4] → [Australis:P4][fixed-in-fx-team]
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P4][fixed-in-fx-team] → [Australis:P4]
Target Milestone: --- → Firefox 29
|
||
Updated•11 years ago
|
|
||
Updated•11 years ago
|
Whiteboard: [Australis:P4] → [Australis:P4][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•