Closed Bug 948396 Opened 11 years ago Closed 11 years ago

[Calendar] Can not scroll anymore the week/day view once the new event has been opened with APZ turned on

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:1.3+, b2g-v1.3 fixed)

RESOLVED FIXED
1.3 Sprint 6 - 12/6
blocking-b2g 1.3+
Tracking Status
b2g-v1.3 --- fixed

People

(Reporter: vingtetun, Assigned: vingtetun)

References

Details

Attachments

(1 file)

Steps to reproduce: - Populate Gaia with some data. |cd $GAIA; make reference-workload-medium;| with the device plugged in. - Open the calendar app - Go to the week view, and scroll it a bit - Click on the '+' sign on the top right corner - Click the back arrow on the top left corner of the new event panel - Try to scroll the week view Expected result: - The week view is scrollable, like it was before Actual result: - The week view does not scroll anymore, or with kats patch for scrollbars I see the scrollbar quickly moving to the top and then nothing more.
It seems like even if the view has been hidden it is still here for APZC I see it while trying to scroll. Before scrolling the week view i see some apzc like: I/Gecko ( 5501): APZC: Setting rect(0.000000 0.000000 320.000000 460.000000) as visible region for APZC 0x47461800 I/Gecko ( 5501): APZC: Using APZC 0x49642000 for layer 0x46c8ac00 with identifiers 20 4 I/Gecko ( 5501): APZC: Setting rect(0.000000 130.000000 320.000000 298.000000) as visible region for APZC 0x49642000 While opening the event view there is a new apzc: I/Gecko ( 5501): APZC: Using APZC 0x48ee3c00 for layer 0x46ae4c00 with identifiers 20 5 I/Gecko ( 5501): APZC: Setting rect(0.000000 50.000000 320.000000 410.000000) as visible region for APZC 0x48ee3c00 Then when I go back and try to scroll the week view the list of APZC is now: I/Gecko ( 5501): APZC: Setting rect(0.000000 0.000000 320.000000 460.000000) as visible region for APZC 0x47461800 I/Gecko ( 5501): APZC: Using APZC 0x48ee3c00 for layer 0x46ae4c00 with identifiers 20 5 I/Gecko ( 5501): APZC: Setting rect(0.000000 50.000000 320.000000 410.000000) as visible region for APZC 0x48ee3c00 I/Gecko ( 5501): APZC: Using APZC 0x49642000 for layer 0x46c8ac00 with identifiers 20 4 I/Gecko ( 5501): APZC: Setting rect(0.000000 130.000000 320.000000 298.000000) as visible region for APZC 0x49642000 So APZC tries to scroll the old apzc :/
Attached patch bug948396.patch (deleted) — Splinter Review
It seems to workaround the issue. My understanding of the calendar app is pretty limited but I wonder if there is not an underlying gecko bug here. I'm fine to work around it for 1.3 purpose though.
Milan let me know what do you think before I ask for a r? on the workaround.
Flags: needinfo?(milan)
Comment on attachment 8345251 [details] [diff] [review] bug948396.patch I don't think I need 2 review but this is like a race. I'm asking r? in advance just because I would like to be ready in advance if we decide to use those and fix the Gecko issue later. Not sure why this one was not displayed none before?
Attachment #8345251 - Flags: review?(kgrandon)
Attachment #8345251 - Flags: review?(gaye)
Comment on attachment 8345251 [details] [diff] [review] bug948396.patch Review of attachment 8345251 [details] [diff] [review]: ----------------------------------------------------------------- ::: apps/calendar/style/ui.css @@ +41,4 @@ > > /* view management */ > > +#modify-event-view { nit: I feel like apps/calendar/style/modify_event_view.css might be a better home, but this is probably fine as well.
Attachment #8345251 - Flags: review?(kgrandon)
Attachment #8345251 - Flags: review?(gaye)
Attachment #8345251 - Flags: review+
(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #2) > Created attachment 8345251 [details] [diff] [review] > bug948396.patch > > It seems to workaround the issue. My understanding of the calendar app is > pretty limited but I wonder if there is not an underlying gecko bug here. > > I'm fine to work around it for 1.3 purpose though. Works for me.
Assignee: nobody → 21
blocking-b2g: --- → 1.3+
Flags: needinfo?(milan)
https://github.com/mozilla-b2g/gaia/commit/11bcf54554ba2f3f50235971b5dcab1631396c16 This patch needs to land in 1.3. I will open a followup to fix the real gecko issue for 1.4.
Status: NEW → RESOLVED
Closed: 11 years ago
Component: Panning and Zooming → Gaia::Calendar
Product: Core → Firefox OS
Resolution: --- → FIXED
Target Milestone: --- → 1.3 Sprint 6 - 12/6
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: