Closed
Bug 953293
Opened 11 years ago
Closed 11 years ago
[Search] App-like results should be rendered together
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
Attachments
(1 file)
App-like results (web results, local apps, marketplace) should be rendered within the same grid.
Assignee | ||
Comment 1•11 years ago
|
||
Amir - this is some work to follow the concepts we discussed in Paris. I've created an 'AppProvider' base class which can abstract some of the rendering logic from each provider which renders to the app grid.
If you could give this one a quick review it would be appreciated. Thanks!
Attachment #8351581 -
Flags: review?(amirn)
Comment 2•11 years ago
|
||
Looks great, much cleaner.
Only 2 things I want to point out:
1. Each new result is appended separately and will trigger a repaint.
Can the 'render' method support rendering a batch of results?
2. Clearing is now less efficient since we need to iterate over all the results.
Can we keep the separate containers for each provider?
Thanks.
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Amir Nissim (Everything.me) from comment #2)
> Looks great, much cleaner.
>
> Only 2 things I want to point out:
> 1. Each new result is appended separately and will trigger a repaint.
> Can the 'render' method support rendering a batch of results?
> 2. Clearing is now less efficient since we need to iterate over all the
> results.
> Can we keep the separate containers for each provider?
Hi Amir, I've gone ahead and updated the pull request to address your concerns. I had thought that using multiple containers would be tricky, but turns out display:inline seems to work well. Please let me know if you have any further concerns.
Comment 4•11 years ago
|
||
Comment on attachment 8351581 [details]
Github pull request
perfect.
Attachment #8351581 -
Flags: review?(amirn) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•