Closed Bug 953293 Opened 11 years ago Closed 11 years ago

[Search] App-like results should be rendered together

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

Attachments

(1 file)

(deleted), text/x-github-pull-request
amirn
: review+
Details
App-like results (web results, local apps, marketplace) should be rendered within the same grid.
Attached file Github pull request (deleted) —
Amir - this is some work to follow the concepts we discussed in Paris. I've created an 'AppProvider' base class which can abstract some of the rendering logic from each provider which renders to the app grid. If you could give this one a quick review it would be appreciated. Thanks!
Attachment #8351581 - Flags: review?(amirn)
Looks great, much cleaner. Only 2 things I want to point out: 1. Each new result is appended separately and will trigger a repaint. Can the 'render' method support rendering a batch of results? 2. Clearing is now less efficient since we need to iterate over all the results. Can we keep the separate containers for each provider? Thanks.
(In reply to Amir Nissim (Everything.me) from comment #2) > Looks great, much cleaner. > > Only 2 things I want to point out: > 1. Each new result is appended separately and will trigger a repaint. > Can the 'render' method support rendering a batch of results? > 2. Clearing is now less efficient since we need to iterate over all the > results. > Can we keep the separate containers for each provider? Hi Amir, I've gone ahead and updated the pull request to address your concerns. I had thought that using multiple containers would be tricky, but turns out display:inline seems to work well. Please let me know if you have any further concerns.
Comment on attachment 8351581 [details] Github pull request perfect.
Attachment #8351581 - Flags: review?(amirn) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: