Closed
Bug 956393
Opened 11 years ago
Closed 11 years ago
[Search] Suggestions results are cleared unexpectedly
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
Attachments
(2 files)
Suggestion results are being cleared. I think this is happening because we call .clear() for all messages (not just suggestion requests).
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•11 years ago
|
||
Also going to take this opportunity to add tests.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8355637 [details]
Pull Request, Follow-up (Testing)
Hi Dale, Amir - This is essentially a very small patch, but I did add a lot of unit tests because I wanted this app to be well tested. If one of you could take a quick look - maybe skim over the tests it would be appreciated. Thanks!
Attachment #8355637 -
Flags: review?(dale)
Attachment #8355637 -
Flags: review?(amirn)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8355637 [details]
Pull Request, Follow-up (Testing)
r+ for the 'clearing results' bugfix, but I am not comfortable reviewing the tests since I'm not familiar with sinon.js
I guess green Travis means the everything is OK, but I would prefer we split the tests to a new bug.
Thanks.
Attachment #8355637 -
Flags: review?(amirn) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8355637 [details]
Pull Request, Follow-up (Testing)
I think you taking a look is good enough for me, but I will probably split up the commits to be safe. Thanks!
Attachment #8355637 -
Flags: review?(dale)
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8355637 -
Attachment description: Github pull request → Pull Request, Follow-up (Testing)
|
|
Assignee | |
Comment 6•11 years ago
|
||
|
|
Assignee | |
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•