Closed
Bug 958254
Opened 11 years ago
Closed 11 years ago
B2G: Assertion during child startup: mozilla::dom::TabChild::HandlePossibleViewportChange
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: gwagner, Assigned: botond)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ajones
:
review+
|
Details | Diff | Splinter Review |
With --enable-debug on current trunk when starting up a downloaded app.
Program received signal SIGSEGV, Segmentation fault.
0xb53b6210 in mozilla::dom::TabChild::HandlePossibleViewportChange (
this=0xb31026e0) at ../../../dom/ipc/TabChild.cpp:593
593 MOZ_ASSERT(NS_SUCCEEDED(rv));
(gdb) bt
#0 0xb53b6210 in mozilla::dom::TabChild::HandlePossibleViewportChange (
this=0xb31026e0) at ../../../dom/ipc/TabChild.cpp:593
#1 0xb53b6710 in mozilla::dom::TabChild::Observe (this=0xb31026e0,
aSubject=<optimized out>, aTopic=<optimized out>, aData=0x0)
at ../../../dom/ipc/TabChild.cpp:365
#2 0xb4cdc204 in nsObserverList::NotifyObservers (this=<optimized out>,
aSubject=0xb2668800, aTopic=0xb6680363 "before-first-paint", someData=0x0)
at ../../../xpcom/ds/nsObserverList.cpp:96
#3 0xb4cdc7ec in NotifyObservers (someData=0x0,
aTopic=0xb6680363 "before-first-paint", aSubject=0xb2668800,
this=0xb3e8f640) at ../../../xpcom/ds/nsObserverService.cpp:302
#4 nsObserverService::NotifyObservers (this=0xb3e8f640, aSubject=0xb2668800,
aTopic=0xb6680363 "before-first-paint", someData=0x0)
at ../../../xpcom/ds/nsObserverService.cpp:290
#5 0xb5975476 in nsBeforeFirstPaintDispatcher::Run (this=0xb213ae90)
at ../../../layout/base/nsPresShell.cpp:507
#6 0xb564cdd4 in nsContentUtils::AddScriptRunner (aRunnable=0xb213ae90)
at ../../../../content/base/src/nsContentUtils.cpp:4743
#7 0xb5977fb2 in UnsuppressAndInvalidate (this=0xb31b8880)
Seems like we hit this code line now because of http://hg.mozilla.org/mozilla-central/annotate/effa95701c83/dom/ipc/TabChild.cpp#l509
Reporter | ||
Comment 1•11 years ago
|
||
I don't know why we assert for rv when a function can clearly return an error.
Updated•11 years ago
|
Blocks: gaia-apzc-2
Assignee | ||
Comment 2•11 years ago
|
||
Looks like that assertion is there by mistake. The next line even checks for NS_FAILED(rv).
Assignee: nobody → botond
Attachment #8358003 -
Flags: review?(ajones)
Comment 3•11 years ago
|
||
Comment on attachment 8358003 [details] [diff] [review]
bug958254.patch
Review of attachment 8358003 [details] [diff] [review]:
-----------------------------------------------------------------
I don't really know what it means for the assertion to fail. The code below just makes it fail more gracefully and makes it compile with assertions off. However GetFirstPaint() does to fail so we should just remove the assertion.
Attachment #8358003 -
Flags: review?(ajones) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•