Closed Bug 961112 Opened 11 years ago Closed 11 years ago

[Search] Add 'Install' text before Marketplace Title

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Search
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

Attachments

(2 files, 2 obsolete files)

Pull request to master
(deleted), text/x-github-pull-request
daleharvey
: review+
Details
Github pull request
(deleted), text/x-github-pull-request
Pike
: review+
Details
We want to differentiate between Marketplace and Everything.me results. To do this, we will add 'Install' text before each Marketplace result.
Attached file Github pull request Rocketbar branch (obsolete) (deleted) —
Attached file Github pull request Rocketbar branch (obsolete) (deleted) —
Attachment #8361812 - Attachment is obsolete: true
Landed in rocketbar: https://github.com/mozilla-b2g/gaia/commit/73f87672b29790e2ac3c35dedae628fedcbb513f
Summary: [Search] Add 'Install' text before Marketplace Title → [IN ROCKETBAR][Search] Add 'Install' text before Marketplace Title
Attached file Pull request to master (deleted) —
Attachment #8361859 - Attachment is obsolete: true
Attachment #8363717 - Flags: review?(dale)
Comment on attachment 8363717 [details] Pull request to master Giving a bit of leway since its early and Francis is crazy busy, but should start getting to a point of doing ui-reviews on these, code is all good though
Attachment #8363717 - Flags: review?(dale) → review+
Landed: https://github.com/mozilla-b2g/gaia/commit/290efee3de3a12c9d803f4650d50bc7c7a8e1f2d
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Summary: [IN ROCKETBAR][Search] Add 'Install' text before Marketplace Title → [Search] Add 'Install' text before Marketplace Title
Can we get a follow with a localization note that's explaining that 'title' is the name of an app to be installed?
(In reply to Axel Hecht [:Pike] from comment #7) > Can we get a follow with a localization note that's explaining that 'title' > is the name of an app to be installed? Sure thing. Would simply changing the variable to 'appName', or 'appTitle' be better?
(In reply to Kevin Grandon :kgrandon from comment #8) > (In reply to Axel Hecht [:Pike] from comment #7) > > Can we get a follow with a localization note that's explaining that 'title' > > is the name of an app to be installed? > > Sure thing. Would simply changing the variable to 'appName', or 'appTitle' > be better? You'd need a new string ID for that, adding a l10n comment seems clear enough to me.
Yeah, what flod said. For future reference, though, yes, appName would have been a much better name for the placable.
Attached file Github pull request (deleted) —
Axel - could you give this a quick review? I just followed the style that we were using for comments elsewhere in the application. Thanks!
Attachment #8365382 - Flags: review?(l10n)
Comment on attachment 8365382 [details] Github pull request Lookin good, thanks. r=me.
Attachment #8365382 - Flags: review?(l10n) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: