Closed Bug 961753 Opened 11 years ago Closed 11 years ago

Do not trigger download in IE on /firefox/new#download-fx

Categories

(www.mozilla.org :: Bedrock, defect)

Production
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: sgarrity, Assigned: agibson)

References

()

Details

(Whiteboard: [kb=1245754] )

Attachments

(1 file)

In order to support linking to /firefox/new in download buttons across mozilla.org, the /firefox/new page will have to NOT trigger the download for IE if you start the page with the #download-fx URL fragment. The download button will have already started a popup-based download when clicked before redirecting to this page in IE. Some background: Internet Explorer, the download buttons on mozilla.org follow a different path than other browsers. The paths are as follows: Most Browsers: 1. Clicking the download button links to /products/download.html?product=firefox-26.0&os=osx&lang=en-US (for example) 2. /products/download.html page starts the download process with the version/locale in the URL variables Internet Explorer: 1. Clicking the download button opens small pop-up window that starts the download and then instantly closes, then redirects the original browser window to the /products/download.html page 2. /products/download.html knows this is IE that the download should already have started from the pop-up, so no auto-download is triggered. IE has this separate path because if a download is triggered by javascript (rather than by a "human" clicking), it presumes it may be unsafe and throws a yellow warning bar. This isn't the case in the latest versions of IE, so it might make sense to limit this path only to older versions, but that's a case for another bug. It appears that we can already link to https://www.mozilla.org/en-US/firefox/new/#download-fx to get to the 2nd-stage of the /firefox/new page and start the download automatically. The only problem I see here is that /firefox/new/#download-fx auto-starts the download even if you are using Internet Explorer. This means a download button with the IE pop-up work-around that then redirects to /firefox/new/#download-fx will start the download twice.
Whiteboard: [kb=1245754]
(In reply to Steven Garrity [:sgarrity] from comment #0) > This isn't the case in the latest versions of IE, so > it might make sense to limit this path only to older versions, but that's a > case for another bug. I think for now it's is perhaps best to prevent the download trigger for IE versions in general, since (I think) on the old php pages they also just check for `/MSIE/` when suppressing the download. Once the download button points to /firefox/new/ for all locales, we could then change the logic on bedrock to only create a popup for IE9 and under.
Assignee: steven → agibson
Status: NEW → ASSIGNED
Attached file GitHub pull request (deleted) —
Gareth: can you check out the last comment here and give us your recommendation? https://github.com/mozilla/bedrock/pull/1631
Flags: needinfo?(garethcull.bugs)
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/9411f0044386907377f51797a2142282d019e3ba [fix bug 961753] Do not trigger download in IE on /firefox/new#download-fx https://github.com/mozilla/bedrock/commit/a593bfb1e34a775c75f4762cb7a34aa0800acb80 Merge pull request #1631 from alexgibson/bug-961753-do-not-trigger-download-in-ie-download-fx [fix bug 961753] Do not trigger download in IE on /firefox/new#download-...
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Chris: I spoke with Alex about this in another bug (#872740) and am fine with waiting until after this is complete.
Flags: needinfo?(garethcull.bugs)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: